Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44774] - [5.2] Web Asset Manager incorect loading of external resource with / at the end

RTC bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
24 Jan 2025

Pull Request for Issue #44759 .

Summary of Changes

Fix for Web Asset Manager incorectly loading an external resource with / at the end

Testing Instructions

Add in to index.php of the site template:

$wa->registerAndUseScript('example.foobar', 'https://example.com/foobar/');
$wa->registerAndUseScript('example.esm', 'foobar/', ['importmap' => true]);

Open site page and check the source code, the header section with scripts.

Actual result BEFORE applying this Pull Request

The path for external script is incorrect, importmap works.

<script type="importmap">{"imports":{"example.esm":"/site-folder/foobar/"}}</script>
...
<script src="/blabla/site-folder/https://example.com/foobar/"></script>

Expected result AFTER applying this Pull Request

The path for external script is correct, importmap works

<script type="importmap">{"imports":{"example.esm":"/site-folder/foobar/"}}</script>
...
<script src="https://example.com/foobar/"></script>

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 24 Jan 2025
avatar Fedik Fedik - change - 24 Jan 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2025
Category ⇒ Libraries
aef35a9 24 Jan 2025 avatar Fedik cs
avatar Fedik Fedik - change - 24 Jan 2025
Labels Added: bug PR-5.2-dev
avatar QuyTon QuyTon - test_item - 28 Jan 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 28 Jan 2025

I have tested this item ✅ successfully on aef35a9

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44774.

avatar pe7er pe7er - test_item - 30 Jan 2025 - Tested successfully
avatar pe7er
pe7er - comment - 30 Jan 2025

I have tested this item ✅ successfully on aef35a9

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44774.

avatar pe7er pe7er - change - 30 Jan 2025
Status Pending ⇒ Ready to Commit
avatar pe7er
pe7er - comment - 30 Jan 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44774.

avatar QuyTon QuyTon - change - 30 Jan 2025
Labels Added: RTC
avatar Hackwar Hackwar - change - 2 Feb 2025
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-02-02 22:18:45
Closed_By ⇒ Hackwar
avatar Hackwar Hackwar - close - 2 Feb 2025
avatar Hackwar Hackwar - merge - 2 Feb 2025
avatar Hackwar
Hackwar - comment - 2 Feb 2025

Thank you for this contribution!

Add a Comment

Login with GitHub to post a comment