PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
22 Jan 2025

Summary of Changes

The mail templates list view shows a list of all available templates from the #__mail_templates table. While doing so, it checks if the associated extension is enabled.

However, it uses the value of the "name" column in the #__extensions table for the subquery (which might hold a human-readable name and not the technical "element" name), causing templates to be not listed if the name and element of the associated extension do not align.

Testing Instructions

  • Temporarly change the value of the "name" column of com_contact in #__extensions from com_contact to Contact
  • List the available mail templates

Actual result BEFORE applying this Pull Request

  • com_contact templates missing

Expected result AFTER applying this Pull Request

  • com_contact templates listed

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [ x] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [ x] No documentation changes for manual.joomla.org needed

avatar SniperSister SniperSister - open - 22 Jan 2025
avatar SniperSister SniperSister - change - 22 Jan 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2025
Category Administration
avatar fgsw fgsw - test_item - 22 Jan 2025 - Tested successfully
avatar fgsw
fgsw - comment - 22 Jan 2025

I have tested this item ✅ successfully on 36cfe70


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44766.

avatar richard67
richard67 - comment - 22 Jan 2025

@SniperSister Is this a bug fix? If yes, it should maybe go into 5.2-dev.

avatar SniperSister SniperSister - change - 22 Jan 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-01-22 14:52:59
Closed_By SniperSister
Labels Added: PR-5.3-dev
avatar SniperSister SniperSister - close - 22 Jan 2025
avatar SniperSister SniperSister - change - 22 Jan 2025
Title
[5.3] Fix extension query in mailtemplates
[5.2] Fix extension query in mailtemplates
avatar SniperSister SniperSister - edited - 22 Jan 2025
avatar SniperSister
SniperSister - comment - 22 Jan 2025

Screwed up the rebase, new PR in #44769

avatar richard67
richard67 - comment - 22 Jan 2025

Thanks. @fgsw Could you redo your test for the new PR #44769 ?

Add a Comment

Login with GitHub to post a comment