RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
21 Jan 2025

Summary of Changes

This PR stems from an update issue. After updating, the /administrator/cache/autoload_psr4.php is deleted and should be regenerated automatically. However the webspace was full and thus the file couldn't be written. In theory we have a fallback for this, however that fallback expects an exception to be thrown, which the code actually doesn't do. This PR adds an additional check for this.

Unfortunately I couldn't replicate the issue itself, since I can't make the folder write-protected on my windows machine and I don't have a Linux machine available right now to test this. So this change was done by me on codereview alone.

Testing Instructions

  1. Delete /administrator/cache/autoload_psr4.php
  2. Make the /administrator/cache folder unwritable
  3. Open the site.

Actual result BEFORE applying this Pull Request

The site displays a 500 error about being unable to include the autoload_psr4.php and the file is not created.

Expected result AFTER applying this Pull Request

The site works like before, even though it might be a bit slower. The autoload_psr4.php is not created.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 21 Jan 2025
avatar Hackwar Hackwar - change - 21 Jan 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2025
Category Libraries
avatar joomdonation joomdonation - test_item - 22 Jan 2025 - Tested successfully
avatar joomdonation
joomdonation - comment - 22 Jan 2025

I have tested this item ✅ successfully on 67e4d51


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44763.

avatar viocassel viocassel - test_item - 22 Jan 2025 - Tested successfully
avatar viocassel
viocassel - comment - 22 Jan 2025

I have tested this item ✅ successfully on 67e4d51


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44763.

avatar QuyTon QuyTon - change - 22 Jan 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar QuyTon
QuyTon - comment - 22 Jan 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44763.

avatar QuyTon QuyTon - change - 22 Jan 2025
Labels Added: RTC
avatar pe7er
pe7er - comment - 26 Jan 2025

I also tested this PR successfully with the permissions on the cache folder set to unwritable (so chmod 500, with only read + execute permission). Site with this PR works without the /administrator/cache/autoload_psr4.php in place.

avatar pe7er pe7er - change - 26 Jan 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-26 15:57:37
Closed_By pe7er
avatar pe7er pe7er - close - 26 Jan 2025
avatar pe7er pe7er - merge - 26 Jan 2025
avatar pe7er
pe7er - comment - 26 Jan 2025

Thanks @Hackwar !

Add a Comment

Login with GitHub to post a comment