[#44753] - [5.2] superfluous space deleted, alpha sorting and wording for pr #39878
- Fixed in Code Base
- 25 Jan 2025
- Medium
- Build: 5.2-dev
- # 44753
- Diff
- tecpromotion:fix-pr-39878
User tests: Successful: Unsuccessful:
Pull Request for PR #39878.
Summary of Changes
PR [5.2] Error handling while create folder in media manager new pr #39878 adds three new strings.
In the first sentence, a space was added at the end. This PR deletes the space.
I would also be in favour of full stops at the end, but that should be of secondary importance for now.
Testing Instructions
code review
Actual result BEFORE applying this Pull Request
COM_MEDIA_CREATE_NEW_FOLDER_EXISTING_FOLDER_ERROR="Folder or file name already exists "
Expected result AFTER applying this Pull Request
COM_MEDIA_CREATE_NEW_FOLDER_EXISTING_FOLDER_ERROR="Folder or file name already exists"
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
Hmm, but then it might sense to add the missing full stop also to the COM_MEDIA_CREATE_NEW_FOLDER_RELATIVE_PATH_ERROR and COM_MEDIA_CREATE_NEW_FOLDER_UNEXPECTED_CHARACTER strings just below.
| Labels |
Added:
Language Change
PR-5.2-dev
|
||
| Title |
|
||||||
Let's keep it shorter to not wrap:
Suggested change:
Let's keep it shorter to not wrap:
Remember that only applies to english
Let's keep it shorter to not wrap:
Remember that only applies to english
Do you have a good idea?
The suggested text is an improvement by @QuyTon. I just wanted to point out that you cant assume that it wont wrap
I appreciate the suggestion from @QuyTon and your comment also makes sense. If you don't have any other suggestions for the time being, I'll adopt this and everyone should be aware that, depending on the translation and language, a change can happen here.
I have tested this item ✅ successfully on e2e3b8e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44753.
I have tested this item ✅ successfully on e2e3b8e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44753.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44753.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-25 17:07:37 |
| Closed_By | ⇒ | pe7er |
Thanks @tecpromotion !
Please add that missing full stop. Our style guide requests sentences and with a .