RTC bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar janschoenherr
janschoenherr
17 Jan 2025

Fixed missing brackets

Testing Instructions

Nothing

Actual result BEFORE applying this Pull Request

Probably broken version string

Expected result AFTER applying this Pull Request

Correct version string

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar janschoenherr janschoenherr - open - 17 Jan 2025
avatar janschoenherr janschoenherr - change - 17 Jan 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2025
Category Libraries
avatar SumCompanyInc SumCompanyInc - test_item - 17 Jan 2025 - Tested successfully
avatar SumCompanyInc
SumCompanyInc - comment - 17 Jan 2025

I have tested this item ✅ successfully on 66ac320

appears the patch has applied the missing brackets.
screenshot of code after patch applied


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44739.
avatar Agapiiii
Agapiiii - comment - 17 Jan 2025

I also tested it, the patch applied the missing brackets.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44739.
avatar Agapiiii Agapiiii - test_item - 17 Jan 2025 - Tested successfully
avatar Agapiiii
Agapiiii - comment - 17 Jan 2025

I have tested this item ✅ successfully on 66ac320

I also tested it, the patch applied the missing brackets.Code Update


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44739.

avatar imejine imejine - test_item - 17 Jan 2025 - Tested successfully
avatar imejine
imejine - comment - 17 Jan 2025

I have tested this item ✅ successfully on 66ac320

tested, it works.
before and after


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44739.

avatar QuyTon QuyTon - change - 17 Jan 2025
Status Pending Ready to Commit
Labels Added: bug PR-5.2-dev
avatar QuyTon
QuyTon - comment - 17 Jan 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44739.

avatar QuyTon QuyTon - change - 17 Jan 2025
Labels Added: RTC
avatar Hackwar Hackwar - change - 17 Jan 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-17 20:00:55
Closed_By Hackwar
avatar Hackwar Hackwar - close - 17 Jan 2025
avatar Hackwar Hackwar - merge - 17 Jan 2025
avatar Hackwar
Hackwar - comment - 17 Jan 2025

Thank you!

avatar heelc29
heelc29 - comment - 18 Jan 2025

@janschoenherr What about line 835?

avatar janschoenherr
janschoenherr - comment - 18 Jan 2025

@janschoenherr What about line 835?

Thanks, I did another PR: #44742

Add a Comment

Login with GitHub to post a comment