? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
6 Oct 2014

Use IcoMoon font for all the signs used in chosen.

Icomoon is almost always loaded in the back end, so we use it for styling the dropdown selects and therefore reduce by one the http requests, and also remove the redundant code for retina displays.

Tests
Apply the patch and navigate to different menus in the administrator area. All the drop downs should be exactly the same.

B/C
None

Easter Egg: In media/jui/less there is a chosen.less file that uses the variables and mixing of bootstrap for further customization (front end or admin)

avatar dgt41 dgt41 - open - 6 Oct 2014
avatar jissues-bot jissues-bot - change - 6 Oct 2014
Labels Added: ?
avatar dgt41 dgt41 - change - 6 Oct 2014
The description was changed
avatar dgt41 dgt41 - change - 6 Oct 2014
The description was changed
avatar brianteeman
brianteeman - comment - 8 Oct 2014

Why is this file moved from /media to /administrator/templates

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4471.

avatar brianteeman
brianteeman - comment - 8 Oct 2014

Easter Egg: In media/jui/less there is a chosen.less file that uses the variables and mixing of bootstrap for further customization (front end or admin)

I dont see this

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4471.

avatar Bakual
Bakual - comment - 8 Oct 2014

Why is this file moved from /media to /administrator/templates

The file isn't moved. He created an override for the Isis template. Which would actually be correct as we don't want to change it for each frontend template as well.

The discussion point may be if we want to have an override in Isis.
The drawback is that it makes maintaining and testing a bit harder as we have two different styling to take care of.

avatar infograf768
infograf768 - comment - 8 Oct 2014

well, the override is in templates/isis/css/jui/chosen.css
I do not see how this file is loaded and I do not see a change in generatecss.php to cope with these changes

avatar Bakual
Bakual - comment - 8 Oct 2014

well, the override is in templates/isis/css/jui/chosen.css
I do not see how this file is loaded

The CSS is loaded here: https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/html/formbehavior.php#L68
This call looks for overrides in the template folder. So this should work imho (haven't tested).

I do not see how this file is loaded and I do not see a change in generatecss.php to cope with these changes

Indeed. It would make sense to add it there since the PR provides a less file.

avatar Bakual
Bakual - comment - 8 Oct 2014

Actually I think the LESS file shouldn't be put into the media/jui folder as it is only a template thing. Yes, other templates may use it, but they likely adjust it anyway and could as well just copy it from the isis template.

avatar brianteeman brianteeman - change - 8 Oct 2014
Category Templates (admin)
avatar dgt41
dgt41 - comment - 8 Oct 2014

@brianteeman @infograf768 @Bakual
The idea is to use an override to get rid of the sprite file that chosen always loads.
This affects only isis, as in this template the inclusion of Icomoon is given
About sustainability: Chosen in the version we are using it, already reached EOL so we are on are owns hereā€¦ (and also chosen is not something that we are gonna touch in every release ???? )
The automated process of generating the css file was an overlook by my, but now is there.

I think this little addition of 2 files worth the prize of reducing the http requests by one

PS In chosen.less i had to copy paste the needed mixins, because using @ import spill some more unneeded code...

avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar tairedweb
tairedweb - comment - 17 Oct 2014

@test success +1

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4471.

avatar tairedweb tairedweb - test_item - 17 Oct 2014 - Tested successfully
avatar micker micker - test_item - 17 Oct 2014 - Tested successfully
avatar dimitargsg
dimitargsg - comment - 17 Oct 2014

@test Tested successfully.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4471.

avatar RamaniBhadresh
RamaniBhadresh - comment - 17 Oct 2014

@test Test Successfully

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4471.

avatar mrunalpittalia mrunalpittalia - change - 17 Oct 2014
Status Pending Ready to Commit
avatar mrunalpittalia
mrunalpittalia - comment - 17 Oct 2014

Moving to RTC as we have 2 successfully tests.

avatar brianteeman brianteeman - change - 17 Oct 2014
Status Ready to Commit Needs Review
avatar brianteeman
brianteeman - comment - 17 Oct 2014

After discussion with @bakual I am setting this Needs Review so the PLT can check

avatar Bakual
Bakual - comment - 17 Oct 2014

Technically, this PR is correctly done.

What I'm wondering is if we really want to do that. It removes one http request which is likely cached anyway.
On the other hand we duplicate the CSS for chosen and make it harder to maintain and test since we now use two different sets, one in System/Protostar and another one in Isis.

avatar brianteeman brianteeman - change - 1 Jan 2015
Labels Removed: ?
avatar dgt41
dgt41 - comment - 6 Jan 2015

@Bakual @roland-d @wilsonge shall I close this one?

avatar roland-d
roland-d - comment - 7 Jan 2015

@dgt41 I agree with @Bakual on this. Closing this PR.

avatar roland-d roland-d - close - 7 Jan 2015
avatar roland-d roland-d - close - 7 Jan 2015
avatar roland-d roland-d - change - 7 Jan 2015
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2015-01-07 09:01:43
avatar dgt41 dgt41 - head_ref_deleted - 14 Aug 2015

Add a Comment

Login with GitHub to post a comment