Joomla! Issue Tracker | Joomla! CMS #44705

No Code Attached Yet

Closed
11 Jan 2025
Medium
Build: 5.2-dev
# 44705

brianteeman
9 Jan 2025

The filesystemhelper is marked as deprecated

joomla-cms/libraries/src/Filesystem/FilesystemHelper.php

Lines 17 to 23 in f30b2cc

    
            * File system helper 
        
            * 
        
            * Holds support functions for the filesystem, particularly the stream 
        
            * 
        
            * @since  1.7.0 
        
            * @deprecated  4.4 will be removed in 6.0 
        
            *              Use Joomla\Filesystem\Helper instead.

However the function fileUploadMaxSize is not marked as deprecated AND is not present in Joomla\Filesystem\Helper

joomla-cms/libraries/src/Filesystem/FilesystemHelper.php

Lines 295 to 306 in f30b2cc

    
               /** 
        
                * Calculates the maximum upload file size and returns string with unit or the size in bytes 
        
                * 
        
                * Call it with JFilesystemHelper::fileUploadMaxSize(); 
        
                * 
        
                * @param   bool  $unitOutput  This parameter determines whether the return value should be a string with a unit 
        
                * 
        
                * @return  float|string The maximum upload size of files with the appropriate unit or in bytes 
        
                * 
        
                * @since   3.4 
        
                */ 
        
               public static function fileUploadMaxSize($unitOutput = true)

brianteeman - open - 9 Jan 2025

joomla-cms-bot - change - 9 Jan 2025

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 9 Jan 2025

brianteeman - change - 9 Jan 2025

The description was changed

brianteeman - edited - 9 Jan 2025

brianteeman - change - 10 Jan 2025

Title

…

FilesystemHelper

[6.0] FilesystemHelper

brianteeman - edited - 10 Jan 2025

Hackwar - change - 11 Jan 2025

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2025-01-11 18:14:25
Closed_By		⇒	Hackwar

Hackwar - close - 11 Jan 2025

Hackwar - comment - 11 Jan 2025

joomla-framework/filesystem#72

brianteeman - comment - 11 Jan 2025

Does it not need to be specifically deprecated? All the other functions are together with info on their replacement

Hackwar - comment - 11 Jan 2025

The class itself is deprecated and can be replaced with the class from the framework package.

brianteeman - comment - 11 Jan 2025

strange as thats not consistent with all the other functions in that file.

Hackwar - comment - 11 Jan 2025

I can guarantee you, that that function will also be deprecated as soon as the filesystem PR is merged.

brianteeman - comment - 11 Jan 2025

Thank you

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#44705] - [6.0] FilesystemHelper

Add a Comment

	* File system helper
	*
	* Holds support functions for the filesystem, particularly the stream
	*
	* @since 1.7.0
	* @deprecated 4.4 will be removed in 6.0
	* Use Joomla\Filesystem\Helper instead.

	/**
	* Calculates the maximum upload file size and returns string with unit or the size in bytes
	*
	* Call it with JFilesystemHelper::fileUploadMaxSize();
	*
	* @param bool $unitOutput This parameter determines whether the return value should be a string with a unit
	*
	* @return float\|string The maximum upload size of files with the appropriate unit or in bytes
	*
	* @since 3.4
	*/
	public static function fileUploadMaxSize($unitOutput = true)