RTC NPM Resource Changed PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
2 Jan 2025

Pull Request for Issue 44636 .

Summary of Changes

This PR has a css change. It will apply a scroll-margin-top when sticky header is used.
The value of scroll-margin-top is set by custom property --cassiopeia-scroll-margin-top with a fallback to 10rem. Because custom property is used it can be set using javascript too. This might be useful when the height of the header is unknown. Out of scope for this PR.

When header in your custom Cassiopea template is larger you can override --cassiopeia-scroll-margin-top to another value in user.css or use javascript to set it in the style element.

Testing Instructions

  • Joomla 5.2-dev with blog sample data
  • Adjust content item "Your Modules" and add an anchor. (I've set it next to "Your site")
  • Add a menu item type = url referring to #anchor. Add it to Menu Blog
  • Refresh homepage and notice new menu item... click on it and see where the page takes you
  • Apply PR and run npm ci to compile new css. (or something similar... css needs to be recompiled)
  • Refresh homepage and notice new menu item... click on it and see where the page takes you

Actual result BEFORE applying this Pull Request

Screenshot 2025-01-02 at 08 10 04

My set anchor position next to Your site is hidden behind the sticky header.

Expected result AFTER applying this Pull Request

Screenshot 2025-01-02 at 08 11 14

My set anchor position next to Your site is visible below the sticky header.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar hans2103 hans2103 - open - 2 Jan 2025
avatar hans2103 hans2103 - change - 2 Jan 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jan 2025
Category Repository NPM Change
avatar fgsw fgsw - test_item - 2 Jan 2025 - Tested successfully
avatar fgsw
fgsw - comment - 2 Jan 2025

I have tested this item ✅ successfully on 18a850a

Used 5.2.2 and Prebuilt Update_Package.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44679.
avatar RickR2H RickR2H - test_item - 6 Jan 2025 - Tested successfully
avatar RickR2H
RickR2H - comment - 6 Jan 2025

I have tested this item ✅ successfully on 18a850a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44679.

avatar RickR2H RickR2H - change - 6 Jan 2025
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 6 Jan 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44679.

avatar hans2103 hans2103 - change - 7 Jan 2025
Labels Added: RTC
avatar 1405djarnis
1405djarnis - comment - 9 Jan 2025

Testet it on 5.2.3 still not working. need somebody to change the Css with next update of Joomla.

avatar fgsw
fgsw - comment - 9 Jan 2025

Testet it on 5.2.3 still not working.

@1405djarnis The Pull Request is not merged.

avatar 1405djarnis
1405djarnis - comment - 9 Jan 2025

Testet it on 5.2.3 still not working.

@1405djarnis The Pull Request is not merged.
(/media/templates/site/cassiopeia/scss/blocks/_global.scss)

avatar hans2103 hans2103 - change - 9 Jan 2025
Labels Added: NPM Resource Changed PR-5.2-dev
avatar pe7er pe7er - change - 12 Jan 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-12 17:45:17
Closed_By pe7er
avatar pe7er pe7er - close - 12 Jan 2025
avatar pe7er pe7er - merge - 12 Jan 2025
avatar pe7er
pe7er - comment - 12 Jan 2025

Thanks @hans2103 !

Add a Comment

Login with GitHub to post a comment