Code Review PR-5.3-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar alikon
alikon
23 Dec 2024

Pull Request for Issue #42671 .

Summary of Changes

ALTER "name" and "title" columns to varchar(255) for #__assets table
ALTER "name" and "title" columns to varchar(255) for #__assets table
ALTER "extension" to varchar(100) for #__categories table
ALTER "extension" to varchar(255) for #__workflows and #__workflow_associations tables

Testing Instructions

code review
and or install this demo extensions
https://test5.richard-fath.de/com_testextensionwithlongname_100.zip
thanks to @richard67

avatar alikon alikon - open - 23 Dec 2024
avatar alikon alikon - change - 23 Dec 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Dec 2024
Category ⇒ SQL Administration com_admin Postgresql Installation
avatar richard67
richard67 - comment - 23 Dec 2024

I don’t think code review is sufficient for testing. I think it needs a real test with creating a category for an extension with a long extension name. This test will then show that there will be other errors happening besides the one mentioned in the issue when using such long category titles.

avatar nileshmittha
nileshmittha - comment - 22 Feb 2025

I have reviewed the code, and it seems fine. However, code review alone isn't enough for testing. We need a real test by creating a category with a long extension name to identify any additional issues beyond the one mentioned


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44664.

avatar alikon alikon - change - 22 Feb 2025
Labels Added: Code Review PR-5.3-dev
avatar alikon
alikon - comment - 22 Feb 2025

yes if someone can share such extension ....

avatar nileshmittha nileshmittha - test_item - 22 Feb 2025 - Tested unsuccessfully
avatar nileshmittha
nileshmittha - comment - 22 Feb 2025

I have tested this item 🔴 unsuccessfully on 30f5be7

Though I mentioned as "code review alone isn't enough for testing", I checked by applying this patch and unfortunately it is not working.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44664.

avatar Tejashrimajage Tejashrimajage - test_item - 22 Feb 2025 - Tested unsuccessfully
avatar Tejashrimajage
Tejashrimajage - comment - 22 Feb 2025

I have tested this item 🔴 unsuccessfully on 30f5be7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44664.

avatar alikon
alikon - comment - 22 Feb 2025

how do you apply the patch ?

avatar alikon alikon - change - 9 Mar 2025
The description was changed
avatar alikon alikon - edited - 9 Mar 2025
avatar alikon alikon - change - 24 Mar 2025
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-03-24 21:47:13
Closed_By ⇒ alikon
avatar alikon alikon - close - 24 Mar 2025
avatar alikon
alikon - comment - 24 Mar 2025

i'll not invest much more time on this

Add a Comment

Login with GitHub to post a comment