RTC NPM Resource Changed PR-5.3-dev Pending

User tests: Successful: 2 fgsw, viocassel Unsuccessful: 0

avatar brianteeman
brianteeman
23 Dec 2024

Summary of Changes

Remove the extra color related css from cassiopeia as they are not needed

See #39379 (comment)

As far as I can tell these extra lines are not needed at all with BS 5.3

Testing Instructions

Create an article with the following

<p><span class="text text-secondary">text-secondary</span> <span class="text text-primary">text-primary</span> <span class="text text-info">text-info</span> <span class="text text-success">text-success</span> <span class="text text-warning">text-warning</span> <span class="text text-danger">text-danger</span></p>
<p class="h1">Example heading <span class="badge bg-primary">bg-primary</span></p>
<p class="h2">Example heading <span class="badge bg-secondary">bg-secondary</span></p>
<p class="h3">Example heading <span class="badge bg-success">bg-success</span></p>
<p class="h4">Example heading <span class="badge bg-danger">bg-danger</span></p>
<p class="h5">Example heading <span class="badge bg-warning">bg-warning</span></p>
<p class="h6">Example heading <span class="badge bg-dark">bg-dark</span></p>

as it is an scss change either use a prebuilt package or npm run build:css

Actual result BEFORE and AFTER applying this Pull Request

image

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 23 Dec 2024
avatar brianteeman brianteeman - change - 23 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Dec 2024
Category Repository NPM Change
avatar fgsw fgsw - test_item - 23 Dec 2024 - Tested successfully
avatar fgsw
fgsw - comment - 23 Dec 2024

I have tested this item ✅ successfully on 3d5593c

Before After
44661-stable 44661-pr

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44661.
avatar viocassel viocassel - test_item - 29 Dec 2024 - Tested successfully
avatar viocassel
viocassel - comment - 29 Dec 2024

I have tested this item ✅ successfully on 3d5593c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44661.

avatar alikon alikon - change - 29 Dec 2024
Status Pending Ready to Commit
Labels Added: NPM Resource Changed PR-5.3-dev
avatar alikon
alikon - comment - 29 Dec 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44661.

avatar rdeutz rdeutz - close - 7 Jan 2025
avatar rdeutz rdeutz - merge - 7 Jan 2025
avatar rdeutz rdeutz - change - 7 Jan 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-07 10:00:55
Closed_By rdeutz
Labels Added: RTC
avatar rdeutz
rdeutz - comment - 7 Jan 2025

Thanks

Add a Comment

Login with GitHub to post a comment