[#44657] - [5.3] Updating wamania/php-stemmer to 4.0.0
- Fixed in Code Base
- 27 Jan 2025
- Medium
- Build: 5.3-dev
- # 44657
- Diff
- Hackwar:5.3-phpstemmer
- Pending continuous-integration/drone/pr Build is pending Details
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
User tests: Successful: 0 Unsuccessful: 0
Partial Pull Request for Issue #44504. (DO NOT CLOSE ORIGINAL ISSUE)
Summary of Changes
wamania/php-stemmer depended on voku/portable-utf8 which seems to have been abandoned and also is a gigantic library. Coincidentally, our joomla/string package has all necessary features for the stemmer, so wamania accepted a PR to switch to our library instead. This PR updates our dependency to version 4.0. Since we unfortunately still have the hard requirement for voku/portable-utf8 in our composer.json, this doesn't change anything in codesize, but it does help with the notices being thrown in PHP 8.4.
Testing Instructions
Codereview.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change |
| Labels |
Added:
Composer Dependency Changed
bug
PR-5.3-dev
|
||
Conflict has been fixed.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-27 06:41:49 |
| Closed_By | ⇒ | laoneo |
Thanks!
Can you document this in the manual. @HLeithner can tell you exactly in which document.
What do we need to document here? There is no difference between the old and new version from our perspective, since we are still shipping with the utf8 library and the only difference between the stemmer version 3 and 4 is, that 4 uses our Joomla String framework class. I don't see what benefit an entry for this in the manual would have.
It might be useful to document all updates on direct dependencies.
Agree here with Harald, we should at least document the major dependency upgrades.
This was discussed in the maintainer meeting and is implementing the change we discussed.