b/c break PR-6.0-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar Hackwar
Hackwar
21 Dec 2024

Summary of Changes

This PR removes CMSObject from a lot of cases in our codebase. The last parts where this is left is the media manager, a few classes and com_finder. For com_finder there is another PR (#43795).

Testing Instructions

Codereview?

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#380

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 21 Dec 2024
avatar Hackwar Hackwar - change - 21 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Dec 2024
Category Administration com_installer com_languages com_media com_menus com_messages com_modules com_plugins com_templates com_users com_workflow Front End com_contact com_content com_tags Libraries Plugins
avatar Hackwar Hackwar - change - 21 Dec 2024
Labels Added: PR-6.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 21 Dec 2024
Category Administration com_installer com_languages com_media com_menus com_messages com_modules com_plugins com_templates com_users com_workflow Front End com_contact com_content com_tags Libraries Plugins Administration com_installer com_languages com_media com_menus com_messages com_modules com_plugins com_tags com_templates com_users com_workflow Front End com_contact com_content Libraries
avatar Hackwar Hackwar - change - 22 Dec 2024
Labels Added: b/c break
avatar Hackwar Hackwar - change - 2 Feb 2025
The description was changed
avatar Hackwar Hackwar - edited - 2 Feb 2025
avatar Bodge-IT Bodge-IT - change - 5 Feb 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-02-05 18:57:17
Closed_By Bodge-IT
avatar Bodge-IT Bodge-IT - close - 5 Feb 2025
avatar Bodge-IT Bodge-IT - merge - 5 Feb 2025
avatar QuyTon
QuyTon - comment - 5 Feb 2025

Maybe related to this PR. Go to System > Site Templates.

An error has occurred.
0 Call to undefined method stdClass::get()
Call Stack
#	Function	Location
1	()	JROOT\administrator\components\com_templates\tmpl\templates\default.php:101
2	include()	JROOT\libraries\src\MVC\View\HtmlView.php:416
3	Joomla\CMS\MVC\View\HtmlView->loadTemplate()	JROOT\libraries\src\MVC\View\HtmlView.php:204
4	Joomla\CMS\MVC\View\HtmlView->display()	JROOT\administrator\components\com_templates\src\View\Templates\HtmlView.php:128
5	Joomla\Component\Templates\Administrator\View\Templates\HtmlView->display()	JROOT\libraries\src\MVC\Controller\BaseController.php:697
6	Joomla\CMS\MVC\Controller\BaseController->display()	JROOT\administrator\components\com_templates\src\Controller\DisplayController.php:68
7	Joomla\Component\Templates\Administrator\Controller\DisplayController->display()	JROOT\libraries\src\MVC\Controller\BaseController.php:730
8	Joomla\CMS\MVC\Controller\BaseController->execute()	JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:143
9	Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch()	JROOT\libraries\src\Component\ComponentHelper.php:361
10	Joomla\CMS\Component\ComponentHelper::renderComponent()	JROOT\libraries\src\Application\AdministratorApplication.php:150
11	Joomla\CMS\Application\AdministratorApplication->dispatch()	JROOT\libraries\src\Application\AdministratorApplication.php:205
12	Joomla\CMS\Application\AdministratorApplication->doExecute()	JROOT\libraries\src\Application\CMSApplication.php:306
13	Joomla\CMS\Application\CMSApplication->execute()	JROOT\administrator\includes\app.php:58
14	require_once()	JROOT\administrator\index.php:32
avatar laoneo
laoneo - comment - 6 Feb 2025

Can you open an issue or event better a pr to fix it?

avatar richard67
richard67 - comment - 23 Mar 2025

That could be fixed with PR #45199 .

Add a Comment

Login with GitHub to post a comment