RTC bug PR-5.2-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar Hackwar
Hackwar
21 Dec 2024

Pull Request for Issue #43505 .

Summary of Changes

When an extension provides a changelog URL in its update XML, a button is displayed to show the changelog, but the URL only loads the changelog from the current extension, not from the update site.

Testing Instructions

  1. Install an old version of a third party extension, for example a language pack.
  2. Search for an update for that extension.
  3. We now try to emulate a changelog available for that extension: Go to the database and in #__updates look for the entry for your extension update. Edit the changelogurl column and insert a URL to a changelog.xml in your sites root, for example http://localhost/changelog.xml
  4. Create a changelog.xml with the content below. (Adapt the content to the extension you've been using for this)
  5. Go to the "update extensions" view and see the button for the changelog for your extension.

Content for the changelog.xml

<changelogs>
	<changelog>
		<element>pkg_ru-RU</element>
		<type>package</type>
		<version>5.2.2.1</version>
		<security>
			<item>Item A</item>
			<item><![CDATA[<h2>You MUST replace this file</h2>]]></item>
		</security>
		<fix>
			<item>Item A</item>
			<item>Item b</item>
		</fix>
	</changelog>
</changelogs>

Actual result BEFORE applying this Pull Request

A modal opens and is empty.

Expected result AFTER applying this Pull Request

A modal opens and shows a few entries

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 21 Dec 2024
avatar Hackwar Hackwar - change - 21 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Dec 2024
Category Administration com_installer
avatar alikon
alikon - comment - 21 Dec 2024

i'm unable to replicate the issue using the current 5.2-dev

image

image

same as #44626 could not replicate the issue

avatar richard67 richard67 - change - 21 Dec 2024
Labels Added: bug PR-5.2-dev
avatar Hackwar
Hackwar - comment - 21 Dec 2024

Did you check, that the URL in the extension table is not set? The problem is, that the code uses the changelog URL of the extension table instead of the updatesite.

avatar alikon
alikon - comment - 21 Dec 2024

ahhh ok removing the changelog url from the extension table i'm able to replicate

avatar alikon alikon - test_item - 21 Dec 2024 - Tested successfully
avatar alikon
alikon - comment - 21 Dec 2024

I have tested this item ✅ successfully on b9f5436


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44652.

avatar Hackwar
Hackwar - comment - 21 Dec 2024

thanks!

avatar viocassel viocassel - test_item - 28 Dec 2024 - Tested successfully
avatar viocassel
viocassel - comment - 28 Dec 2024

I have tested this item ✅ successfully on b9f5436


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44652.

avatar alikon alikon - change - 28 Dec 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 28 Dec 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44652.

avatar pe7er pe7er - change - 12 Jan 2025
Labels Added: RTC
avatar pe7er pe7er - change - 12 Jan 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-12 14:41:16
Closed_By pe7er
avatar pe7er pe7er - close - 12 Jan 2025
avatar pe7er pe7er - merge - 12 Jan 2025
avatar pe7er
pe7er - comment - 12 Jan 2025

Thanks @Hackwar !

Add a Comment

Login with GitHub to post a comment