[#4465] - addAttachment() causing Strict-standard error
- Closed
- 11 Oct 2014
- Medium
- Build: staging
- # 4465
- Diff
- itbra:patch-26
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Change 1: Function signature - added 5th parameter for content disposition because its absense is causing the Strict-Standard error Strict Standards: Declaration of JMail::addAttachment() should be compatible with PHPMailer::addAttachment($path, $name = '', $encoding = 'base64', $type = '', $disposition = 'attachment') in /libraries/joomla/mail/mail.php on line 22
Change 2: The function parameters encoding, type, disposition are always of type string. I changed the type note to reflect this.
jissues-bot
- | Labels |
Added:
?
|
||
Ah... right after your comment i noticed this PR should be associated to 3.4-dev's phpmailer, because currently Joomla is deployed with phpmailer 5.2.6 whereas my previous PR which updates this library to 5.2.8 and introduces the extended method see line 2047 in in phpmailer.php. Since i'm using 5.2.8 here i forgot about this and added this PR at the wrong place. I'll delete it and make a new one at the right place.
Sorry for the confusion!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-11 21:11:15 |
Well that's interesting - PHPMailer::addAttachement() do not have this 5th param. Am I missing something?