RTC PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
17 Dec 2024

Summary of Changes

Fix duplicate entry with the action logs by removing the second call to onJoomlaAfterUpdate

Testing Instructions

  • Install the latest version of Joomla
  • Check the action logs
  • Reinstall the core from com_joomlaupdate
  • Check the action logs again
  • change the update server to this generated one: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.2-dev/44629/downloads/80905/pr_list.xml
  • Install the update
  • check the action logs again
  • reinstall the core files
  • check the action logs again

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar zero-24 zero-24 - open - 17 Dec 2024
avatar zero-24 zero-24 - change - 17 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Dec 2024
Category Administration com_joomlaupdate
avatar zero-24 zero-24 - change - 17 Dec 2024
The description was changed
avatar zero-24 zero-24 - edited - 17 Dec 2024
avatar zero-24 zero-24 - change - 17 Dec 2024
The description was changed
avatar zero-24 zero-24 - edited - 17 Dec 2024
avatar zero-24 zero-24 - change - 17 Dec 2024
The description was changed
avatar zero-24 zero-24 - edited - 17 Dec 2024
avatar zero-24 zero-24 - change - 17 Dec 2024
The description was changed
avatar zero-24 zero-24 - edited - 17 Dec 2024
avatar fgsw fgsw - test_item - 17 Dec 2024 - Tested successfully
avatar fgsw
fgsw - comment - 17 Dec 2024

I have tested this item ✅ successfully on 99cf048

Test by prebuilt package:
Untitled


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44629.
avatar alikon alikon - test_item - 17 Dec 2024 - Tested successfully
avatar alikon
alikon - comment - 17 Dec 2024

I have tested this item ✅ successfully on 99cf048


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44629.

avatar alikon alikon - change - 17 Dec 2024
Status Pending Ready to Commit
Labels Added: PR-5.2-dev
avatar alikon
alikon - comment - 17 Dec 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44629.

avatar richard67 richard67 - change - 17 Dec 2024
Title
[5.2] Fix dublicate enty with the action logs by removing the seccond call to onJoomlaAfterUpdate
[5.2] Fix duplicate enty with the action logs by removing the seccond call to onJoomlaAfterUpdate
avatar richard67 richard67 - edited - 17 Dec 2024
avatar richard67 richard67 - change - 17 Dec 2024
Title
[5.2] Fix duplicate enty with the action logs by removing the seccond call to onJoomlaAfterUpdate
[5.2] Fix duplicate entry with the action logs by removing the second call to onJoomlaAfterUpdate
avatar richard67 richard67 - edited - 17 Dec 2024
avatar richard67 richard67 - change - 17 Dec 2024
The description was changed
avatar richard67 richard67 - edited - 17 Dec 2024
avatar zero-24
zero-24 - comment - 17 Dec 2024

Thanks you both that was fast 👍

avatar laoneo
laoneo - comment - 17 Dec 2024

Just wondering why it was called twice at all and this todo survived so long.

avatar zero-24
zero-24 - comment - 17 Dec 2024

Just wondering why it was called twice at all and this todo survived so long.

I'm wondering the same i have also noticed all the "Updated from Unknown to XX" messages but never looked deeper until this night where i used the plugin event myself ;)

avatar pe7er pe7er - change - 18 Dec 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-12-18 23:33:56
Closed_By pe7er
Labels Added: RTC
avatar pe7er pe7er - close - 18 Dec 2024
avatar pe7er pe7er - merge - 18 Dec 2024
avatar pe7er
pe7er - comment - 18 Dec 2024

Thanks @zero-24 !

Add a Comment

Login with GitHub to post a comment