RTC Language Change PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 Dec 2024

Pull Request for Issue #24291 .

Summary of Changes

Since 23704 the db name validation in the installer is stricter than the config component

Testing Instructions

In the global config options try to change the database name to something with a forbidden character eg for mysql add a \

Actual result BEFORE applying this Pull Request

Database connection test failed with the following error: 1049: Unknown database 'test_joomla'

Expected result AFTER applying this Pull Request

The database name is invalid. It must not contain the following characters: \ /

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 15 Dec 2024
avatar brianteeman brianteeman - change - 15 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Dec 2024
Category Administration com_config Language & Strings
avatar brianteeman brianteeman - change - 15 Dec 2024
Labels Added: Language Change PR-5.3-dev
avatar brianteeman
brianteeman - comment - 15 Dec 2024

@richard67 appreciate the review but please leave it for me to approve/accept the changes

avatar fgsw fgsw - test_item - 16 Dec 2024 - Tested successfully
avatar fgsw
fgsw - comment - 16 Dec 2024

I have tested this item ✅ successfully on aaa4f89

Result BEFORE applying this Pull Request Result AFTER applying this Pull Request
Screen Shot 2024-12-16 at 08 13 30 Screen Shot 2024-12-16 at 08 22 14

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623.
avatar ChristineWk ChristineWk - test_item - 16 Dec 2024 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 16 Dec 2024

I have tested this item ✅ successfully on aaa4f89


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623.

avatar alikon alikon - change - 16 Dec 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 16 Dec 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623.

avatar rdeutz rdeutz - change - 7 Jan 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-07 09:31:29
Closed_By rdeutz
Labels Added: RTC
avatar rdeutz rdeutz - close - 7 Jan 2025
avatar rdeutz rdeutz - merge - 7 Jan 2025
avatar rdeutz
rdeutz - comment - 7 Jan 2025

Thanks

Add a Comment

Login with GitHub to post a comment