[#44615] - [5.3] System template offline RTL
- Fixed in Code Base
- 7 Jan 2025
- Medium
- Build: 5.3-dev
- # 44615
- Diff
- brianteeman:system_offline_rtl
User tests: Successful: Unsuccessful:
Summary of Changes
By using logical css properties and removing unused css we can remove the system-site-offline RTL css file. One less file to maintain!
Testing Instructions
Set site to offline in global configuration
Set site language to an RTL language such as persian
Rename the cassiopeia offline.php so that we are using the fallback system template's offline.php
As this involves removing a css file and rebuilding an scss file either use a prebuilt package or do a full npm ci
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No visible change
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change Front End Templates (site) |
chmst
- | Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44615.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-07 09:30:21 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
RTC
NPM Resource Changed
PR-5.3-dev
|
||
Thanks
I have tested this item ✅ successfully on 8d85c87
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44615.