RTC NPM Resource Changed PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
12 Dec 2024

Summary of Changes

Use logical CSS properties to avoid having to set different LTR and RTL css

Previously browsers didnt support logical css properties for floats. They do now https://caniuse.com/?search=float-inline

Testing Instructions

Switch to an RTL language
As this is a scss change then you will need to either rebuild the css or test with a prebuilt package

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

There should be no visible difference after this PR

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 12 Dec 2024
avatar brianteeman brianteeman - change - 12 Dec 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Dec 2024
Category Repository NPM Change
avatar fgsw fgsw - test_item - 13 Dec 2024 - Tested successfully
avatar fgsw
fgsw - comment - 13 Dec 2024

I have tested this item ✅ successfully on 99d0d9f

5.2.2-stable

1-stable

Prebuilt package

2-j44613


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44613.
avatar chmst chmst - alter_testresult - 14 Dec 2024 - quy: Tested successfully
avatar alikon
alikon - comment - 16 Dec 2024

setting RTC cause it was successfully tested by @Quy too

avatar alikon alikon - change - 16 Dec 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 16 Dec 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44613.

avatar rdeutz rdeutz - close - 7 Jan 2025
avatar rdeutz rdeutz - merge - 7 Jan 2025
avatar rdeutz rdeutz - change - 7 Jan 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-07 09:29:45
Closed_By rdeutz
Labels Added: RTC NPM Resource Changed PR-5.3-dev
avatar rdeutz
rdeutz - comment - 7 Jan 2025

Thanks

Add a Comment

Login with GitHub to post a comment