[#4461] - Ensure vars are always set if the default menu item is retrieved (Ref #4183)
- Closed
- 5 Oct 2014
- Medium
- Build: staging
- # 4461
- Diff
- mbabker:routerFix
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This solves the edge case reported in #4183 where the redirect for a contact form being the site's homepage does not route as expected. It was found that when the default menu item is being pulled, the vars from the query are not being set to the class object, which causes the redirect fail.
jissues-bot
- | Labels |
Added:
?
|
||
I'll do tests on the 3.4 branch with this merged.
On Sun, Oct 5, 2014 at 9:56 AM, George Wilson notifications@github.com
wrote:
@test https://github.com/test works as described. replicated the 404
and the patch fixed it. Would like to see some unit tests though as the
3.4-dev branch has 100% test coverage for this branch - we should add a
test case to prevent the bug reoccurring!—
Reply to this email directly or view it on GitHub
#4461 (comment).
Updated test results and set to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4461.
| Status | Pending | ⇒ | Ready to Commit |
Thanks for testing!
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-05 15:11:04 |
| Milestone | |||
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
@test works as described. replicated the 404 and the patch fixed it. Would like to see some unit tests though as the 3.4-dev branch has 100% test coverage for this branch - we should add a test case to prevent the bug reoccurring!