[#44600] - [5.3] Admin: Contact view does not load with a large user base
- Fixed in Code Base
- 7 Jan 2025
- Medium
- Build: 5.3-dev
- # 44600
- Diff
- brianteeman:batch_user
User tests: Successful: Unsuccessful:
Pull Request for Issue #41187 .
Summary of Changes
This PR removes the ability when using batch functions to set/change the linked user. As this loads all users on the site into a giant list it impacts performance of all functionality in the contact component list view. With enough users it can even prevent the page from loading.
I can't see a valid use case for even having the functionality to link multiple contacts to the same user.
The field to select the users is therefore removed from the batch modal and the related files and strings are therefore marked as deprecated without replacement
Testing Instructions
Open the batch modal for the contact manager
Actual result BEFORE applying this Pull Request
Option to mass set linked user
Expected result AFTER applying this Pull Request
Option no longer present
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact Language & Strings Layout |
I have tested this item ✅ successfully on f5db2d4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.
I have tested this item ✅ successfully on f5db2d4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.
I know this is more a user backwards compatibility break and doesn't fall into our bc policy. If necessary I would like to remove stuff only in a major version, except when it is urgent, which is here not the case. An admin can do a layout override now till 6.0 is released.
I disagree. This is a bug fix. Telling someone to create an override to fix a bug is not the correct thing to do. As per the original bug report this useless function prevents the correct operation of anything in the com_contact list view as the query is run on page load and not just when the modal opens
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-07 09:22:55 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
RTC
Language Change
PR-5.3-dev
|
||
Thanks
I have tested this item ✅ successfully on f5db2d4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.