[#44571] - [5.3] Fix author not being updated in Tagged Item upon saving article
- Pending
- Medium
- Build: 5.3-dev
- # 44571
- Diff
- janschoenherr:patch-15
User tests: Successful: Unsuccessful:
Currently, when saving an article, the core_created_user_id and core_created_by_alias fields are not updated in the corresponding entry in the #__ucm_content table.
Summary of Changes
Add both fields to the fields_mapping column in the #__content_types table for articles.
Testing Instructions
A test should be to make a new installation with this PR to see if the changes in the base.sql are right, and another test should be made to update an existing 5.3.x to the patched package created by Drone for this PR to see if the update SQL script is run and has no errors.
After that (new installation or update), change the author (Created By) of an article. Take a look at the corresponding entry in the #__ucm_content table.
Actual result BEFORE applying this Pull Request
core_created_user_id and core_created_by_alias are not updated.
Expected result AFTER applying this Pull Request
core_created_user_id and core_created_by_alias are updated.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql |
You are probably right. I will check it out.
| Labels |
Added:
PR-5.3-dev
|
||
| Category | SQL Installation Postgresql | ⇒ | SQL Administration com_admin Postgresql Installation |
I added the update sql files. I am not sure about the postgresql syntax. Can someone confirm, that it works?
@janschoenherr Could you rename your update SQL script? Currently they are named "5.3.0-2024-12-03.sql", but meanwhile we have something newer with "5.3.0-2024-12-19.sql" in the 5.3-dev branch, so your scripts should have a newer date than that, at least "5.3.0-2024-12-20.sql", but maybe better take the date of today and use "5.3.0-2025-01-23.sql".
Thanks in advance.
@janschoenherr Could you rename your update SQL script? Currently they are named "5.3.0-2024-12-03.sql", but meanwhile we have something newer with "5.3.0-2024-12-19.sql" in the 5.3-dev branch, so your scripts should have a newer date than that, at least "5.3.0-2024-12-20.sql", but maybe better take the date of today and use "5.3.0-2025-01-23.sql".
Thanks in advance.
✅
| Labels |
Added:
Updates Requested
|
||
Prebuilt packages are not available for download.
| Labels |
Removed:
Updates Requested
|
||
Something wrong in prebuilt packages:
As a user I'd like to leave a small comment: this feature is needed for correct using Tags layout in Yootheme Pro page builder. E.g. there is a menu item 'Compact list of tagged items' and it would be very useful to display a name of a user assigned to the article as the author despite the fact the original content was created by admin.
Here is what we can get on blog category page using user fields (avatar):
There are different authors assigned to the articles and their avatars.
And here is what we get on tagged items page:
There is the only original author who created the articles.
This PR could help in such situation for many users and I hope this PR will be noticed someday and accepted.
Thanks for attention.
@Sulpher I've updated this PR so it is ready for testing again. If you want to bring it forward, please test it and submit the test result in the issue tracker here by using the blue "Text this" button at the top-left corner.
A test should be to make a new installation with this PR to see if the changes in the base.sql are right, and another test should be made to update an existing 5.3.x to the patched package created by Drone for this PR to see if the update SQL script is run and has no errors.
Thanks in advance.
P.S. It might come too late for the upcoming 5.3.3 as this is already in preparation, but it still makes sense to bring it forward so it can go into 5.3.4.
@janschoenherr I've allowed myself to update the branch of this PR so new packages are created by Drone for testers, rename the update SQL scripts so that they run when updating from a current 5.3.x, and add instructions for new installation and update to the testing instructions. So the PR is ready for testing. Let's hope we find testers. Thanks a lot for your patience.
| Labels |
Added:
PBF
bug
|
||
I have tested this item ✅ successfully on 83b58e4
i've got this working!
thank you @janschoenherr and everyone progressing the advancement of this!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44571.
Does this also need an update sql? Otherwise the changes will only be for new installs