Feeling Lucky
PR-5.2-dev
[#44567] - [5.2] Fix return typehint in IdentityAware trait
- Fixed in Code Base
- 6 Dec 2024
- Medium
- Build: 5.2-dev
- # 44567
- Diff
- joomla:fix/docblock/identity
- Pending continuous-integration/drone/push Build is running Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
User tests: Successful: Unsuccessful:
Summary of Changes
Sync the return type of IdentityAware::getIdentity() method with CMSApplicationInterface
Testing Instructions
Run PHPStan with for relevant code or code review
Actual result BEFORE applying this Pull Request
Before PHPStan doesn't detect the return of null and would always expect an User object
Expected result AFTER applying this Pull Request
PHPStan expects null or User
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.2-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-12-06 15:08:30 |
| Closed_By | ⇒ | Hackwar |
Thank you for the contribution.