Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44540] - [5.2] Tags: Make router discover 404s properly

RTC bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
27 Nov 2024

Pull Request for Issue #43543.

Summary of Changes

The tags router will accept any input as a valid URL as long as there is at least one valid tag among them.

Testing Instructions

  1. Create a menu item to list all tags
  2. Have one or more tags
  3. Tag an item
  4. go to the frontend and got to the tag
  5. Add a random string to the URL, for example /jhgh

Actual result BEFORE applying this Pull Request

URL returns a valid page.

Expected result AFTER applying this Pull Request

URL returns a 404.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00
avatar Hackwar Hackwar - open - 27 Nov 2024
avatar Hackwar Hackwar - change - 27 Nov 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2024
Category ⇒ com_tags Front End
avatar fgsw fgsw - test_item - 27 Nov 2024 - Tested successfully
avatar fgsw
fgsw - comment - 27 Nov 2024

I have tested this item ✅ successfully on c90258c

Call Stack

# Function Location
1 () JROOT/libraries/src/Router/Router.php:155
2 Joomla\CMS\Router\Router->parse() JROOT/libraries/src/Application/SiteApplication.php:754
3 Joomla\CMS\Application\SiteApplication->route() JROOT/libraries/src/Application/SiteApplication.php:244
4 Joomla\CMS\Application\SiteApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
5 Joomla\CMS\Application\CMSApplication->execute() JROOT/includes/app.php:58
6 require_once() JROOT/index.php:32
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44540.
avatar Quy Quy - test_item - 30 Nov 2024 - Tested successfully
avatar Quy
Quy - comment - 30 Nov 2024

I have tested this item ✅ successfully on c90258c

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44540.

avatar Quy Quy - change - 30 Nov 2024
Status Pending ⇒ Ready to Commit
Labels Added: bug PR-5.2-dev
avatar Quy
Quy - comment - 30 Nov 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44540.

avatar pe7er pe7er - close - 2 Dec 2024
avatar pe7er pe7er - merge - 2 Dec 2024
avatar pe7er pe7er - change - 2 Dec 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-12-02 14:46:45
Closed_By ⇒ pe7er
Labels Added: RTC
avatar pe7er
pe7er - comment - 2 Dec 2024

Thanks @Hackwar !

avatar Slava287
Slava287 - comment - 24 Jan 2025

Hello. Work. Thanks!

Add a Comment

Login with GitHub to post a comment