[#44532] - [5.2] Fix double closing Curly braces in inline style
- Fixed in Code Base
- 28 Nov 2024
- Medium
- Build: 5.2-dev
- # 44532
- Diff
- cyrezdev:patch-58
User tests: Successful: Unsuccessful:
Fix double closing Curly braces in inline style for :root[data-color-scheme="dark"] {
Summary of Changes
Remove the extra curly brace.
Testing Instructions
Just a look at code.
Actual result BEFORE applying this Pull Request
Nothing changed
Expected result AFTER applying this Pull Request
Nothing changed
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I have tested this item ✅ successfully on 11e5841
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44532.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.2-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44532.
The PR fixes the wrong double closing curly brackets in the style, so I've tested with success and set RTC as it has 2 good tests.
However, it would be nice if the indentation one line above could be fixed, too. See my previous comment #44532 (comment) . It would not need new tests if that would be fixed with this PR.
Otherwise, if this PR gets merged without that additional fix, one can make a new PR.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-28 08:54:30 |
| Closed_By | ⇒ | Hackwar |
Thank you for this fix!
I have tested this item ✅ successfully on 11e5841
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44532.