Feature RTC a11y PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Nov 2024

Pull Request for Issue #37442 and more .

Summary of Changes

This pull request focuses on improving accessibility by ensuring that visually hidden text is properly included for screen readers. The changes primarily involve modifying how icons/images and their corresponding text are handled in the components/com_contact directory.

Accessibility Improvements:

  • There is no visible change with this PR
  • When using icons there is no change
  • When using images instead of icons it marks the images as decorative and correctly provides a definition term (dt) so that it ensures that screen readers can still access the necessary information without displaying it visually
  • When using "none" instead of icons it correctly provides a definition term (dt) so that it ensures that screen readers can still access the necessary information without displaying it visually

Bug Fix

  • Although the component options let you select an image instead of an icon there was no code to render it
  • The icons and the images used the same class so they could not be styled differently. This PR introduces a new css class for the images

Testing Instructions

  • Go to Global Configuration -> Component -> Contacts -> Icon panel
  • Set Settings drop-down list to Icons
  • Select any picture for the Icons
  • Create a contact, add every contact datas (name, address, email, etc.)
  • Display the created contact using any kind of template (preferable Cassiopeia) which doesn't use template override for the file "components/com_contact/tmpl/contact/default_address.php"
  • Check the alt text of the images of email
  • Check that there is a valid dt text

Actual result BEFORE applying this Pull Request

When using images the dt is only an image with an alt description. This is not a valid dt AND the text for contact was using the wrong language string value

Expected result AFTER applying this Pull Request

When using images or icons or any mix thereof all images are marked as decorative and icons are aria-hidden AND there is a valid dt for each element marked as screen reader only

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 25 Nov 2024
avatar brianteeman brianteeman - change - 25 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Nov 2024
Category Front End com_contact
avatar brianteeman brianteeman - change - 25 Nov 2024
The description was changed
avatar brianteeman brianteeman - edited - 25 Nov 2024
avatar brianteeman brianteeman - change - 25 Nov 2024
Title
[5.3] Contact form icons etc [a11y]
[5.3] Contact icons etc [a11y]
avatar brianteeman brianteeman - edited - 25 Nov 2024
avatar brianteeman brianteeman - change - 25 Nov 2024
Labels Added: PR-5.3-dev
4fb1228 25 Nov 2024 avatar brianteeman colon
avatar Quy
Quy - comment - 26 Nov 2024

Address and Email don't have the colon.

44523-contact

avatar brianteeman
brianteeman - comment - 26 Nov 2024

@Quy - should be fixed now

avatar Quy Quy - test_item - 29 Nov 2024 - Tested successfully
avatar Quy
Quy - comment - 29 Nov 2024

I have tested this item ✅ successfully on 5f9541b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44523.

avatar fgsw fgsw - test_item - 30 Nov 2024 - Tested successfully
avatar fgsw
fgsw - comment - 30 Nov 2024

I have tested this item ✅ successfully on 5f9541b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44523.

avatar Quy Quy - change - 30 Nov 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 30 Nov 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44523.

avatar rdeutz rdeutz - change - 3 Dec 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-12-03 14:03:42
Closed_By rdeutz
Labels Added: Feature RTC a11y
avatar rdeutz rdeutz - close - 3 Dec 2024
avatar rdeutz rdeutz - merge - 3 Dec 2024
avatar rdeutz
rdeutz - comment - 3 Dec 2024

Thanks

avatar brianteeman
brianteeman - comment - 3 Dec 2024

Thanks

Add a Comment

Login with GitHub to post a comment