[#44521] - [5.2] User: Allow MFA before password reset
- Fixed in Code Base
- 18 Dec 2024
- Medium
- Build: 5.2-dev
- # 44521
- Diff
- Hackwar:5.2-mfa-reset
User tests: Successful: Unsuccessful:
Pull Request for Issue #43311, #39895, #38788, #29576.
Summary of Changes
When having MFA enabled for a user, you can't log out, can't force a password reset and can't setup MFA after first login.
Testing Instructions
- Create a user and setup MFA for that user. Save the user.
- For this new user, set the "Require password reset" flag.
- Try to login from the frontend.
- Setup a second user and have the user configuration enforce MFA for that usergroup.
- Force the user to reset their password
- Try to login from the frontend.
- Setup a third user without MFA (remember to disable enforcing MFA in the user configuration again)
- Force the user to reset their password
- Login with the user and try to logout again
Actual result BEFORE applying this Pull Request
The user is stuck in a redirect loop or can't logout.
Expected result AFTER applying this Pull Request
1-3 The user gets shown the MFA captive view and can type in the required code. Afterwards the user is redirected to a page to update their password.
4-6 The user is redirected to setup MFA and then to reset their password.
7-9 The user is able to logout
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
bug
PR-5.2-dev
|
||
| Labels |
Added:
b/c break
|
||
This should be b/c now. Please test (again).
@Hackwar
I successfully tested this on Joomla 5.2.2.
The user profile is presented, and the password was changed successfully - no loops or errors.
I still have some concerns with the implementation. When the user enters their current password, they are redirected to the index of the site and the profile is displayed requiring the PW change. But I am still able to view and read items on my index.
I feel that it should not allow viewing of anything but the profile page.
Thank you for taking this issue on it has prevented me from rolling out an updated J4/5 site since none of my users could reset their passwords without manual intervention form the admin.
steve
@Stevec4 can you open https://issues.joomla.org/tracker/joomla-cms/44521 and
- login with your github-account
- click button "Test this"
- mark "Tested successfully"
Now the test count as successfull.
I have tested this item ✅ successfully on f7778c3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44521.
@fgsw Sorry forgot to submit the test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44521.
| Labels |
Removed:
b/c break
|
||
I have tested this item ✅ successfully on 9c16296
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44521.
| Status | Pending | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Pending |
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44521.
pe7er
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-12-18 22:51:19 |
| Closed_By | ⇒ | pe7er | |
| Labels |
Added:
RTC
|
||
This breaks any extension using password_reset_password_tasks to add additional allowed URLs since the new checkUserRequiresReset is now checking only password_reset_password_urls.
Shouldn't checkUserRequiresReset also be checking password_reset_password_tasks? Otherwise you've introduce a backwards compatibility break in a point release. We've just had to do an emergency fix and release because of this.. please stop doing this in minor/point releases.
This needs to be moved to a new method and the old method needs a deprecation to be b/c