Feature RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
23 Nov 2024

Pull Request for Issue #42208.

Summary of Changes

The tags router currently does not fix incomplete URL parts like other components. Specifically it does not look up the alias for tags which were only references by an ID and didn't have the slug like expected. The code also unifies the IDs to be arrays as expected.

Testing Instructions

Look up the ID of a tag of your choice which isn't directly linked via a menu item. Go into an article of your choosing and insert the following:

<a href="index.php?option=com_tags&view=tag&id=5">Test</a>

Adapt the &id=5 to the ID of your chosen tag.

Actual result BEFORE applying this Pull Request

The URL will look something like this: `http://domain.tld/tags-component/all-tags/5.html

Expected result AFTER applying this Pull Request

The URL will look something like this: `http://domain.tld/tags-component/all-tags/lime.html

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 23 Nov 2024
avatar Hackwar Hackwar - change - 23 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2024
Category com_tags Front End
avatar Hackwar Hackwar - change - 24 Nov 2024
Labels Added: PR-5.3-dev
avatar Quy Quy - test_item - 26 Nov 2024 - Tested successfully
avatar Quy
Quy - comment - 26 Nov 2024

I have tested this item ✅ successfully on 6d553a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44515.

avatar fgsw fgsw - test_item - 26 Nov 2024 - Tested successfully
avatar fgsw
fgsw - comment - 26 Nov 2024

I have tested this item ✅ successfully on 6d553a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44515.

avatar alikon alikon - change - 26 Nov 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 26 Nov 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44515.

avatar rdeutz rdeutz - close - 3 Dec 2024
avatar rdeutz rdeutz - merge - 3 Dec 2024
avatar rdeutz rdeutz - change - 3 Dec 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-12-03 14:05:57
Closed_By rdeutz
Labels Added: Feature RTC
avatar rdeutz
rdeutz - comment - 3 Dec 2024

Thanks

Add a Comment

Login with GitHub to post a comment