Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44514] - [6.3] Custom Fields: Trigger deprecation on non-numeric item-ID

Feature PR-6.0-dev Code Review Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
23 Nov 2024

Summary of Changes

Custom fields currently allow to use non-numeric IDs for the content items. This is a huge problem, because because of that the itemid column in #__fields_values is a varchar and this dramatically slows down any access to that table. Eventually we want to convert this column to integer. This PR for now triggers an error when a non-numeric ID is used.

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 23 Nov 2024
avatar Hackwar Hackwar - change - 23 Nov 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2024
Category ⇒ Administration com_fields
avatar HLeithner
HLeithner - comment - 23 Nov 2024

Only a problem on mysql and maybe mariadb

avatar HLeithner
HLeithner - comment - 4 Mar 2025

This pull request has been automatically rebased to 6.0-dev.

avatar HLeithner HLeithner - change - 4 Mar 2025
Title
…
[5.3] Custom Fields: Trigger deprecation on non-numeric item-ID
[6.0] Custom Fields: Trigger deprecation on non-numeric item-ID
avatar HLeithner HLeithner - edited - 4 Mar 2025
avatar Hackwar Hackwar - change - 16 Jun 2025
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-06-16 20:29:56
Closed_By ⇒ Hackwar
Labels Added: Feature PR-6.0-dev Code Review
avatar Hackwar Hackwar - close - 16 Jun 2025
avatar Hackwar Hackwar - change - 17 Jun 2025
Status Closed ⇒ New
Closed_Date 2025-06-16 20:29:56 ⇒
Closed_By Hackwar ⇒
avatar Hackwar Hackwar - change - 17 Jun 2025
Status New ⇒ Pending
avatar Hackwar Hackwar - reopen - 17 Jun 2025
avatar HLeithner
HLeithner - comment - 31 Aug 2025

This pull request has been automatically rebased to 6.1-dev.

avatar HLeithner HLeithner - change - 31 Aug 2025
Title
…
[6.0] Custom Fields: Trigger deprecation on non-numeric item-ID
[6.1] Custom Fields: Trigger deprecation on non-numeric item-ID
avatar HLeithner HLeithner - edited - 31 Aug 2025
avatar HLeithner
HLeithner - comment - 17 Mar 2026

This pull request has been automatically rebased to 6.2-dev.

avatar tecpromotion tecpromotion - change - 15 Apr 2026
Title
…
[6.1] Custom Fields: Trigger deprecation on non-numeric item-ID
[6.2] Custom Fields: Trigger deprecation on non-numeric item-ID
avatar tecpromotion tecpromotion - edited - 15 Apr 2026
avatar HLeithner
HLeithner - comment - 6 Nov 2026

This pull request has been automatically rebased to 6.3-dev. Joomla! 6.2 is now in feature freeze.

avatar HLeithner HLeithner - change - 11 Nov 2026
Title
…
[6.2] Custom Fields: Trigger deprecation on non-numeric item-ID
[6.3] Custom Fields: Trigger deprecation on non-numeric item-ID
avatar HLeithner HLeithner - edited - 11 Nov 2026

Add a Comment

Login with GitHub to post a comment