Feature RTC PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
23 Nov 2024

Pull Request for Issue # .

Summary of Changes

This pull request (PR) deleted the "5.2.2-2024-09-24.sql" update SQL scripts from the sources and adds them to the list of files to be deleted on update in the script.php file.

Testing Instructions

Code review, or if you want to do a real test:

Update a recent 5.3-dev nightly build to the latest 6.0-dev nightly build to get the actual result, and update a recent 5.3-dev nightly build to the patched package created by Drone for this PR to get the expected result.

The latest 5.3-dev nightly build can be found here: https://developer.joomla.org/nightlies/Joomla_5.3.0-alpha1-dev-Development-Full_Package.zip

The latest 6.0-dev nightly build update package can be found here: https://developer.joomla.org/nightlies/Joomla_6.0.0-alpha1-dev-Development-Update_Package.zip

The patched package created by Drone can be found here: https://artifacts.joomla.org/drone/joomla/joomla-cms/6.0-dev/44512/downloads/80513/Joomla_6.0.0-alpha1-dev+pr.44512-Development-Update_Package.zip

Actual result BEFORE applying this Pull Request

After an update from a recent 5.3-dev nightly build to the latest 6.0-dev nightly build, the files administrator/components/com_admin/sql/updates/mysql/5.2.2-2024-09-24.sql and administrator/components/com_admin/sql/updates/postgresql/5.2.2-2024-09-24.sql are present.

But that should not be the case, there should not be any 5.x update SQL scripts.

Expected result AFTER applying this Pull Request

After an update from a recent 5.3-dev nightly build to the patched package created by Drone for this PR, there are no 5.x update SQL scripts in folders administrator/components/com_admin/sql/updates/mysql and administrator/components/com_admin/sql/updates/postgresql.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 23 Nov 2024
avatar richard67 richard67 - change - 23 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2024
Category Administration com_admin SQL Postgresql
avatar richard67 richard67 - change - 23 Nov 2024
The description was changed
avatar richard67 richard67 - edited - 23 Nov 2024
avatar fgsw fgsw - test_item - 27 Nov 2024 - Tested successfully
avatar fgsw
fgsw - comment - 27 Nov 2024

I have tested this item ✅ successfully on da42975

Test by real test.

  • Update latest 5.3-dev nightly build > latest 6.0-dev nightly build shows files administrator/components/com_admin/sql/updates/mysql/5.2.2-2024-09-24.sql and administrator/components/com_admin/sql/updates/postgresql/5.2.2-2024-09-24.sql.
  • Update latest 5.3-dev nightly build > Joomla_6.0.0-alpha1-dev+pr.44512-Development-Update_Package.zip shows no files administrator/components/com_admin/sql/updates/mysql/5.2.2-2024-09-24.sql and administrator/components/com_admin/sql/updates/postgresql/5.2.2-2024-09-24.sql.
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44512.
avatar Bodge-IT Bodge-IT - change - 28 Nov 2024
Labels Added: Feature PR-6.0-dev
avatar Bodge-IT Bodge-IT - test_item - 28 Nov 2024 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 28 Nov 2024

I have tested this item ✅ successfully on 2d81885

Files in PR package are 6.0 sql/postgres files only.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44512.

avatar Bodge-IT Bodge-IT - change - 28 Nov 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-11-28 19:36:17
Closed_By Bodge-IT
Labels Added: RTC
avatar Bodge-IT Bodge-IT - close - 28 Nov 2024
avatar Bodge-IT Bodge-IT - merge - 28 Nov 2024
avatar Bodge-IT
Bodge-IT - comment - 28 Nov 2024

thanks @richard67 and @fgsw for testing

Add a Comment

Login with GitHub to post a comment