[#44509] - [5.2] CoreButtonsTrait back() generates wrong button text
- Fixed in Code Base
- 2 Dec 2024
- Medium
- Build: 5.2-dev
- # 44509
- Diff
- pAnd0rASBG:5.2-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #44432 .
Summary of Changes
Changed back function to use $text instead of 'back'
Testing Instructions
$toolbar = Toolbar::getInstance(); $toolbar->back('foobar');
Actual result BEFORE applying this Pull Request
<a href="javascript:history.back();">back</a>
Expected result AFTER applying this Pull Request
<a href="javascript:history.back();">foobar</a>
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
bug
PR-5.2-dev
|
||
@pAnd0rASBG Can you give more instructions how to test?
e.g. in /administrator/components/com_banners/src/View/Clients/HtmlView.php after Line 131 $toolbar->addNew('client.add');, add $toolbar->back('foobar');
Then go to Components > Banners > Clients in backend.
Old behavior:
Corrected behavior:
I have tested this item ✅ successfully on 8a9c3d6
@pAnd0rASBG Thanks for help to test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44509.
I have tested this item ✅ successfully on 8a9c3d6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44509.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44509.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-12-02 14:42:04 |
| Closed_By | ⇒ | pe7er | |
| Labels |
Added:
RTC
|
||
Thanks @pAnd0rASBG !
@pAnd0rASBG Can you give more instructions how to test?