Feature Language Change PR-5.3-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar brianteeman
brianteeman
21 Nov 2024

Pull Request for Issue # .

Summary of Changes

When adding a thumbnail image for a contact it was hard coded to use the contact name as the alt text description. This is an invalid use of the alt text description.

This PR adds the ability to create your own valid alt text description or to mark it as a decorative image

Doing this in a way that is backwards compatible is challenging - still testing that

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 21 Nov 2024
avatar brianteeman brianteeman - change - 21 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2024
Category Administration com_contact Language & Strings Front End SQL Installation
a64d774 21 Nov 2024 avatar brianteeman post
avatar brianteeman brianteeman - change - 21 Nov 2024
Labels Added: Language Change PR-5.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2024
Category Administration com_contact Language & Strings Front End SQL Installation SQL Administration com_admin Postgresql com_contact Language & Strings Front End Installation
31c8bfc 21 Nov 2024 avatar brianteeman post
avatar ChristineWk ChristineWk - test_item - 23 Nov 2024 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 23 Nov 2024

I have tested this item ✅ successfully on 31c8bfc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44502.

avatar brianteeman
brianteeman - comment - 23 Nov 2024

@ChristineWk thanks for testing but this is still a draft and not ready for testing

@chmst The problem here is what do we do with existing contacts?
On a new contact image it would behave the same as a new article image. If there is an alt text description then it is used. If the checkbox for decorative is checked then an empty alt text description is used and if neither field is entered then no alt description is provided.
The problem is that on an existing site you do have an alt text description on all contact images generated from the contact title. We know thats not a good alt text description but I also dont believe we should alter an existing sites data by removing that. With the current code proposal all existing contact images would have their alt text removed making an existing site potentially less accessible than it was before.

avatar brianteeman brianteeman - change - 25 Nov 2024
Labels Added: Feature

Add a Comment

Login with GitHub to post a comment