PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Nov 2024

Pull Request for Issue #37442 and more .

Summary of Changes

This pull request focuses on improving accessibility by ensuring that visually hidden text is properly included for screen readers. The changes primarily involve modifying how icons/images and their corresponding text are handled in the components/com_contact directory.

Accessibility Improvements:

There is no visible change with this PR
When using icons there is no change
When using images instead of icons it marks the images as decorative and correctly provides a definition term (dt) so that it ensures that screen readers can still access the necessary information without displaying it visually

Testing Instructions

  • Go to Global Configuration -> Component -> Contacts -> Icon panel
  • Set Settings drop-down list to Icons
  • Select any picture for Custom Email Icon
  • Create a contact, add every contact datas (name, address, email, etc.)
  • Display the created contact using any kind of template (preferable Cassiopeia) which doesn't use template override for the file "components/com_contact/tmpl/contact/default_address.php"
  • Check the alt text of the selected image of email
  • Check that there is a valid dt text

Actual result BEFORE applying this Pull Request

When using images the dt is only an image with an alt description. This is not a valid dt AND the text for contact was using the wrong language string value

Expected result AFTER applying this Pull Request

When using images or icons or any mix thereof all images are marked as decorative and icons are aria-hidden AND there is a valid dt for each element marked as screen reader only

image

This PR is only for the address. Any comments about anything not touched by this PR will simply result in this PR being deleted

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 21 Nov 2024
avatar brianteeman brianteeman - change - 21 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2024
Category Front End com_contact
avatar brianteeman brianteeman - change - 21 Nov 2024
The description was changed
avatar brianteeman brianteeman - edited - 21 Nov 2024
avatar brianteeman brianteeman - change - 21 Nov 2024
The description was changed
avatar brianteeman brianteeman - edited - 21 Nov 2024
avatar brianteeman brianteeman - change - 21 Nov 2024
The description was changed
avatar brianteeman brianteeman - edited - 21 Nov 2024
avatar Quy
Quy - comment - 21 Nov 2024

For Settings Text, label is doubled.

    <dt>
                    <span class="jicons-text">
                Email:             </span>
                <span class="visually-hidden">Email</span>
    </dt>
avatar brianteeman brianteeman - close - 22 Nov 2024
avatar brianteeman
brianteeman - comment - 22 Nov 2024

back to the drawing board. need to understand what #35963 is doing

avatar brianteeman brianteeman - change - 22 Nov 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-11-22 10:33:52
Closed_By brianteeman
Labels Added: PR-5.3-dev

Add a Comment

Login with GitHub to post a comment