[#4449] - Add events onContentBeforeSave and onContentAfterSave
- Closed
- 8 Nov 2014
- Medium
- Build: staging
- # 4449
- Diff
- jissereitsma:feature-menuitem-events
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The frustration of many developers is that the Menu Item models and Menu models are outdated and lack the flexibility of events. This commit adds the onContentBeforeSave() and onContentAfterSave() calls to Menu Item, reusing code from the JModelAdmin (even though that class lives in the legacy folder).
jissues-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Administration Plugins |
Thanks for the pointer. I've now created a custom repository, with a test plugin that logs to the Joomla logs folder when this patch is used in Joomla. It allows for testing this properly. Test instructions are available in that repository as well: https://github.com/yireo/plg_content_menuitemstest
Test works. Nice addition which has been requested for quite a while!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4449.
By the way, you should make this support onContentChangeState too.
Thanks for the test. As for the suggestion on implementing onContentChangeState as well - that was my idea as well. But let's take this step by step. There are many more events to implement :)
Thanks for noticing. Will do.
infograf768
- | Labels |
Added:
?
|
||
I've tested the other patch and it is solid. I will close this PR because the functionality is also available in the other PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-08 03:39:52 |
Thanks @yireo to add that feature. Please could you provide test instructions? Maybe a plugin to trigger these two events.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4449.