User tests: Successful: Unsuccessful:
Pull Request for Issue #34501 .
in the element sorting field on the page, the STAGE field is at the very bottom, however, I remember exactly that we previously saved the order in this field relative to the actual location in the table (in this case, the stage line should be the second after ORDERING).
This pull request includes changes to the workflow-related sorting options in the content management system. The changes ensure that these options are only available when the workflow feature is enabled AND that they are positioned in the filter in the correct position
Workflow-related sorting options:
administrator/components/com_content/forms/filter_articles.xml
: Added new sorting options JSTAGE_ASC
and JSTAGE_DESC
that require the workflow feature to be enabled.Conditional form field handling:
administrator/components/com_content/src/Model/ArticlesModel.php
: Removed the addition of workflow-related sorting options within the getFilterForm
method when the workflow feature is enabled, as this is now handled directly in the form definition.Conditional option inclusion:
libraries/src/Form/Field/ListField.php
: Added a check to exclude options that require the workflow feature if the workflow feature is not enabled.Using Sample Data
Test 1. Enable workflows and observe in the sort filter dropdown the position of Stage Asc/Desc in the list
Test 2. Disable Workflows and observe that Stage Asc/Desc is not present in the list
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_content Libraries |
Labels |
Added:
PR-5.3-dev
|
I have tested this item ✅ successfully on d44ec3c
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
@Quy @Kostelano I forgot to do the same for the featured articles list - please can you additionally test that
I have tested this item ✅ successfully on d223bd3
I have tested this item ✅ successfully on d223bd3
I have tested this item ✅ successfully on d44ec3c
The fix works
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486.