[#44483] - [5.2] Fix fixFilesystemPermissions method in script.php for not existing folder
- Fixed in Code Base
- 19 Nov 2024
- Medium
- Build: 5.2-dev
- # 44483
- Diff
- richard67:5.2-dev-fix-filesystem-fix-folder-not-exists
User tests: Successful: Unsuccessful:
Pull Request for Issue #44482 .
Summary of Changes
This pull request (PR) fixes an error in the "fixFilesystemPermissions" method which was added to script.php with my PR #44379 for fixing files and folder permissions when updating from 5.2.0 or 5.2.1.
When you have a 5.2.0 or 5.2.1 site with a long update history, it might be that e.g. the "images/sampledata/cassiopeia" folder is missing because we do not include the sample data images in our update packages.
It can also be that an administrator has deleted that folder in the media manager, which is also a valid use case.
In this case the "fixFilesystemPermissions" method causes an exception because it tries to get the list of files for a not existing folder.
This PR fixes that.
Testing Instructions
On a 5.2.0 or 5.2.1 site, delete the folder "images/sampledata/cassiopeia" (or rename it if you want to restore it later).
Then switch on "Debug System" in global configuration and set "Error Reporting" to "Maximum".
Then update to either 5.2.2-rc1 or a current 5.3-dev nightly build to get the actual result.
Or with the same starting conditions, update to the patched package https://artifacts.joomla.org/drone/joomla/joomla-cms/5.2-dev/44483/downloads/80427/Joomla_5.2.2-rc1+pr.44483-Release_Candidate-Update_Package.zip or custom update URL https://artifacts.joomla.org/drone/joomla/joomla-cms/5.2-dev/44483/downloads/80427/pr_list.xml created by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
See issue #44482 .
Expected result AFTER applying this Pull Request
Update succeeds.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
Tested using the patch tester.
@dautrich Please follow exactly my testing instructions. It does not matter if the patch is applied with patch tester before the update or now. It only matters to which package you are updating. You have updated to 5.2.2-rc1, that will produce the actual result. When updating from 5.2.0 or 5.2.1 to the patched package created for this PR, then you will get the expected result.
The first step of the update is to unpack the files from the zip. After that, the new script.php extracted from that zip is used. So it does not have an effect if the PR is applied before the update and you are updating to a package which does not contain the fix from this PR.
I have tested this item ✅ successfully on 05467d0
Tested with custom update URL https://artifacts.joomla.org/drone/joomla/joomla-cms/5.2-dev/44483/downloads/80427/pr_list.xml
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44483.
I have tested this item ✅ successfully on 05467d0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44483.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Release Blocker
PR-5.2-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44483.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-19 19:01:36 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
RTC
|
||
Thank you for this contribution.
sorry I'm late to testing this but as it was my bug report just wanted to say I finally got the time to test and confirm it works
I have tested this item 🔴 unsuccessfully on 05467d0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44483.