[#44480] - [6.0] Router: Enforce suffix by default if enabled
- Pending
- Medium
- Build: 6.0-dev
- # 44480
- Diff
- Hackwar:6.0-router-tainted-ref
User tests: Successful: Unsuccessful:
Summary of Changes
This PR changes the feature introduced in 5.2.0 to be able to enforce a suffix ending if it is enabled and makes this the standard behavior. It removes the option from the SEF plugin and moves the code to the SiteRouter class, at the same time using the "tainted URL" feature from #44455 to prevent unnecessary redirects.
Testing Instructions
- Enable SEF URLs with suffix ending.
- Open a random URL of the site and remove the suffix
- Open a random URL of the site and replace the suffix with something else and add
?format=htmlto the URL - Open a random URL of the site, remove the suffix and add
?format=htmlto the URL
Actual result BEFORE applying this Pull Request
Joomla loads all the URLs without any redirects.
Expected result AFTER applying this Pull Request
All URLs are redirected to the version with .html at the end.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries Front End Plugins |
| Labels |
Added:
Language Change
PR-6.0-dev
|
||
| Category | Administration Language & Strings Libraries Front End Plugins | ⇒ | Administration Language & Strings SQL Installation Postgresql Libraries Front End Plugins |
That is why it says "tainted URL" feature from #44455 and since that PR is not merged yet, this PR indeed fails.
I changed this to draft since it's not ready
I added the b/c break label because technically it removes anoption and forces this behavior on everyone, even though it is the expected behavior.
| Labels |
Added:
Feature
b/c break
|
||
I have tested this item ✅ successfully on 7950bcb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44480.
Could you clarify the testing instructions? Without the patch applied, and using this url: http://localhost/joomla-cms6/en/content-component/single-article (which is the Australian Parks article in the testing data) I get a 301 response - permanent 301 redirect. All the tests work the same without the patch applied. That is, I get the behaviour the patch is supposed to produce.
With the patch applied all pages produce an error:
0 Call to undefined method Joomla\CMS\Router\SiteRouter::setTainted()
Call Stack
# Function Location
1 () JROOT/libraries/src/Router/SiteRouter.php:203
2 Joomla\CMS\Router\SiteRouter->parseFormat() JROOT/libraries/src/Router/Router.php:384
3 Joomla\CMS\Router\Router->processParseRules() JROOT/libraries/src/Router/Router.php:144
4 Joomla\CMS\Router\Router->parse() JROOT/libraries/src/Application/SiteApplication.php:754
5 Joomla\CMS\Application\SiteApplication->route() JROOT/libraries/src/Application/SiteApplication.php:244
6 Joomla\CMS\Application\SiteApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
7 Joomla\CMS\Application\CMSApplication->execute() JROOT/includes/app.php:58
8 require_once() JROOT/index.php:32
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/44480">issues.joomla.org/tracker/joomla-cms/44480</a>.</sub>
@ceford with which Joomla version did you test this? The code you mentioned is only available in recent versions of Joomla 6.
I use a local clone and update it often, last time being a few days ago. And from time to time I throw it away and start again. The last commit message for this test was May 28:
[6.0] Workflow: use generic AbstractApplication in type hint (#43155)
I have tested this item 🔴 unsuccessfully on 9873b77
* install pr
Expected a smooths transition, at least not a fatal error