PR-5.2-dev PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
16 Nov 2024

Pull Request for Issue # .

Summary of Changes

The method createRestorationFile is deprecated and should not be used anymore. This PR replaces it with createUpdateFile.

Testing Instructions

Code Review? Otherwise: install an old version of Joomla, apply patch and then update

Actual result BEFORE applying this Pull Request

Update works

Expected result AFTER applying this Pull Request

Update works

avatar bembelimen bembelimen - open - 16 Nov 2024
avatar bembelimen bembelimen - change - 16 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2024
Category Administration com_joomlaupdate
avatar richard67 richard67 - test_item - 16 Nov 2024 - Tested successfully
avatar richard67
richard67 - comment - 16 Nov 2024

I have tested this item ✅ successfully on 4a556e8

Code review. As the deprecated createRestorationFile method is just a call to the createUpdateFile method with the same parameters and return values, the change is correct.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44466.

avatar HLeithner HLeithner - change - 16 Nov 2024
Labels Added: PR-5.2-dev
avatar HLeithner HLeithner - close - 16 Nov 2024
avatar HLeithner HLeithner - merge - 16 Nov 2024
avatar HLeithner HLeithner - change - 16 Nov 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-11-16 18:57:10
Closed_By HLeithner
Labels Added: PR-5.3-dev
avatar HLeithner
HLeithner - comment - 16 Nov 2024

thanks

avatar HLeithner HLeithner - change - 16 Nov 2024
Title
[5.2] Replace deprecated createRestorationFile with createUpdateFile
[5.3] Replace deprecated createRestorationFile with createUpdateFile
avatar HLeithner HLeithner - edited - 16 Nov 2024

Add a Comment

Login with GitHub to post a comment