PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
13 Nov 2024

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in script.php to the latest changes in the 5.3-dev branch.

Currently there are only files from PR #44296 .

Testing Instructions

Code review and check the description of PR #44296 , or compare a recent 5.3-dev nightly build with a 5.2-dev nightly build and check for files which exist only in the 5.2-dev but not in 5.3-dev build.

Actual result BEFORE applying this Pull Request

The files added by this PR to the list are still there after an update from 5.2.x to 5.3-dev.

Expected result AFTER applying this Pull Request

The files added by this PR to the list are deleted after an update from 5.2.x to 5.3-dev.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 13 Nov 2024
avatar richard67 richard67 - change - 13 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2024
Category Administration com_admin
avatar richard67
richard67 - comment - 13 Nov 2024

@dgrammatiko As you have removed the build/media_source/system/scss/joomla-core-loader.scss from the sources with your PR #44296 : Can we safely delete the files on update? Or should we keep them for b/c reasons in case if a 3rd party extensions still uses them or refers to them?

avatar dgrammatiko
dgrammatiko - comment - 13 Nov 2024

It's safe to remove those files as they where used exclusively during the bundling, they won't affect the web component as it already has those encapsulated (either before or after the PR #44296).
In sort, this is good, thanks

avatar richard67
richard67 - comment - 13 Nov 2024

@dgrammatiko Thanks for the quick reply.

avatar bembelimen bembelimen - change - 16 Nov 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-11-16 19:12:43
Closed_By bembelimen
Labels Added: PR-5.3-dev
avatar bembelimen bembelimen - close - 16 Nov 2024
avatar bembelimen bembelimen - merge - 16 Nov 2024
avatar bembelimen
bembelimen - comment - 16 Nov 2024

Thx

Add a Comment

Login with GitHub to post a comment