User tests: Successful: Unsuccessful:
Pull Request for Issue #43528 .
When multiple taxonomy items have the same title but belong to different categories, only the last one is kept in the filter array because the title is used as the array key, causing earlier items with the same title to be overwritten.
All taxonomy items are correctly preserved in the filter array, even when they share the same title, because they are stored using numeric indices instead of using the title as the array key.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_finder |
Title |
|
Title |
|
I have tested this item successfully ✅
Labels |
Added:
PR-5.2-dev
|
I understand what you are trying to do, but this unfortunately is an incomplete fix. There are 3 places, where $this->filters
is written to and they all use the title. So we would need to fix all of them. At the same time the title is also used in administrator/components/com_finder/src/Service/HTML/Query.php and that would break with this change. Maybe we could work directly with the whole object from the database, but then this would have to wait until Joomla 6 to be merged. The way this is now we unfortunately can't merge this.
@hendrikbehncke How to mark a test as successfull:
Now the test count as successfull.
This info is not for this Pull Request by the comment of @Hackwar above.
Labels |
Added:
bug
|
Category | Administration com_finder | ⇒ | Administration com_finder Front End |
Hi, we updated the search filter fix and keep the title but index the array by id. The places where the title was accessed are also updated to use the id indexed array.
Sorry this slipped under the radar, it would be really great if someone could look into the updated fix.
@thanhnv37 @hendrikbehncke please test this Pull Request.