No Code Attached Yet
avatar Steinweber
Steinweber
8 Nov 2024

Steps to reproduce the issue

$toolbar = Toolbar::getInstance(); $toolbar->back('foobar');

Expected result

<a href="javascript:history.back();">foobar</a>

Actual result

<a href="javascript:history.back();">back</a>

System information (as much as possible)

5.2.0

Additional comments

public function back(string $text = 'JTOOLBAR_BACK'): LinkButton

Current:

public function back(string $text = 'JTOOLBAR_BACK'): LinkButton
    {
        return $this->link('back', $text)
            ->url('javascript:history.back();');
    }

Solution:

public function back(string $text = 'JTOOLBAR_BACK'): LinkButton
    {
        return $this->link($text, 'javascript:history.back();');
    }
avatar Steinweber Steinweber - open - 8 Nov 2024
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2024
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Nov 2024
avatar chmst
chmst - comment - 15 Nov 2024

@Steinweber as you know the solution, would you like to make a PR?

avatar Quy Quy - change - 22 Nov 2024
Status New Closed
Closed_Date 0000-00-00 00:00:00 2024-11-22 18:14:52
Closed_By Quy
avatar Quy Quy - close - 22 Nov 2024
avatar Quy
Quy - comment - 22 Nov 2024

PR #44509

Add a Comment

Login with GitHub to post a comment