Too bad this bug was not fixed with 5.2.1. As long as the bug persists, we have to stay with 5.1 ;(

should this be solved with #44426 ?

No. #44426 is to fix the code Hannes removed in error from com_content. Possibly this issue can be fixed with another PR to fix the code removed from com_modules

Found the problem - it doesnt switch because the second filter to select the menu needs to be unselected

Perhaps someone who understand the javascript can fix this.
Basically what is needed is for the second filter to be set to "- Select Menu -" whenever the first filter is changed from Site to Admin and vice versa

@brianteeman I was able to reproduce the issue without adding a new menu.
Navigating to Menu → Bottom Menu does not update the site/admin filter, which remains stuck on "site."

@Hemang360 thats because you have installed the sample data which includes multiple menus. My instructions were for everyone so they may not have multiple menus already.

Hi @brianteeman,

I have been looking into this issue and wanted to confirm my understanding before going further.
I reproduced the bug by creating an additional Administrator Menu module with a link to Menu Items and publishing it in the menu position. When opening the page through that custom admin menu, the filter always shows Site instead of Administrator.
While debugging, I noticed the generated link looks like this:

index.php?option=com_menus&view=items&menutype=

Since it doesn’t include client_id=1, the page appears to load with the default client (Site).
I also explored the SearchTools JavaScript and tried resetting the menutype filter when client_id changes, based on your comment that the second filter needs to be unset. However, that doesn’t seem to address the initial state when the page is opened from the admin menu.

Before preparing a PR, could you confirm whether the intended fix should be adjusting the admin menu link generation (like adding client_id=1), or handling it in JavaScript when the client filter changes?

No thats not the problem.

The problem is that you cannot switch from site to admin menu items in the drop down filter

This is because when you try to change that filter the second filter should be reset so that you can select which admin menu (not item) you want but thats not possible

I believe that when you change that to Admin then the second filter should be changed to only display admin menus. It looks like there is some JS that tries to do that but it doesnt work or I misread the JS which is perfectly possible and there is no code to do that and its needed