PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar leeroy1821
leeroy1821
3 Nov 2024

Pull Request for Issue #40653 .

Summary of Changes

\Joomla\CMS\Workflow\Workflow constructor now use CMSApplicationInterface insteadof CMSApplication. This make compatible with CliApplication which implements CMSApplicationInterface but not extends CMSApplication.

Testing Instructions

Make CLI app which create instance of ArticleModel: $article = \Joomla\CMS\Factory::getApplication()->bootComponent('com_content')->getMVCFactory()->createModel('Article', 'Administrator');

Actual result BEFORE applying this Pull Request

[TypeError] Joomla\CMS\Workflow\Workflow::__construct(): Argument #2 ($app) must be of type ?Joomla\CMS\Application\CMSApplication, Joomla\CMS\Application\ConsoleApplication given, called in ....../libraries/src/MVC/Model/WorkflowBehaviorTrait.php on line 90

Expected result AFTER applying this Pull Request

I get model object

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar leeroy1821 leeroy1821 - open - 3 Nov 2024
avatar leeroy1821 leeroy1821 - change - 3 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2024
Category Libraries
avatar alikon
alikon - comment - 3 Nov 2024

see pr #43155 too

avatar leeroy1821 leeroy1821 - close - 3 Nov 2024
avatar leeroy1821
leeroy1821 - comment - 3 Nov 2024

Okay, so Joomla can not fix this problem. Understand.

avatar leeroy1821 leeroy1821 - change - 3 Nov 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-11-03 09:55:16
Closed_By leeroy1821
Labels Added: PR-5.2-dev
avatar alikon
alikon - comment - 3 Nov 2024

i'm sorry that was not my message, just want to put a link to more info

Add a Comment

Login with GitHub to post a comment