RTC PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
31 Oct 2024

Pull Request for Issue # .

Summary of Changes

The update SQL scripts "5.2.0-2024-09-24.sql" which were added with PR #44133 should have been renamed to "5.2.1-2024-09-24.sql" before merging because 5.2.0 was already released at that time.

This PR here does that now.

If a 5.2.1 will be released in the next days which does not contain these files because it only fixes the file system permissions, they have to be renamed again to "5.2.2-2024-09-24.sql".

The wrong file name is not a problem for updating as the date is newer than the newest 5.2.0 script present before an update, so the version of the file is still newer than the schema version in the database before the update, and so the script will run.

But it should have the right version in its name so nobody is confused.

Testing Instructions

Code review, and check if the files "5.2.0-2024-09-24.sql" can be found in a 5.2.0 installation or update package.

Actual result BEFORE applying this Pull Request

Update SQL scripts are named "5.2.0-2024-09-24.sql" but can't be found in a 5.2.0.

Expected result AFTER applying this Pull Request

Update SQL scripts are named "5.2.1-2024-09-24.sql".

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 31 Oct 2024
avatar richard67 richard67 - change - 31 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2024
Category SQL Administration com_admin Postgresql
avatar brianteeman brianteeman - test_item - 1 Nov 2024 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Nov 2024

I have tested this item ✅ successfully on 8ae1636


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44388.

avatar alikon alikon - test_item - 1 Nov 2024 - Tested successfully
avatar alikon
alikon - comment - 1 Nov 2024

I have tested this item ✅ successfully on 8ae1636


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44388.

avatar alikon alikon - change - 1 Nov 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 1 Nov 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44388.

avatar Hackwar Hackwar - change - 1 Nov 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-11-01 16:48:42
Closed_By Hackwar
Labels Added: RTC PR-5.2-dev
avatar Hackwar Hackwar - close - 1 Nov 2024
avatar Hackwar Hackwar - merge - 1 Nov 2024
avatar Hackwar
Hackwar - comment - 1 Nov 2024

Thank you for your contribution!

Add a Comment

Login with GitHub to post a comment