RTC bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
31 Oct 2024

Pull Request for Issue #44373
.

Summary of Changes

rewrite the query

Testing Instructions

create content with few words
be sure it indexed by Smart search component
add module Smart search to site
type word into search edit

Actual result BEFORE applying this Pull Request

No suggestions

Expected result AFTER applying this Pull Request

suggestions

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar alikon alikon - open - 31 Oct 2024
avatar alikon alikon - change - 31 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2024
Category Front End com_finder
b05272d 31 Oct 2024 avatar alikon cs
avatar alikon alikon - change - 31 Oct 2024
Labels Added: PR-5.2-dev
9aecdf7 31 Oct 2024 avatar alikon cs
avatar alikon alikon - change - 31 Oct 2024
The description was changed
avatar alikon alikon - edited - 31 Oct 2024
avatar softarius
softarius - comment - 15 Nov 2024

It works for me in Postgresql 16.4, MySQL 8 and MariaDB 5.6
@richard67 I'm asking you to merge this PR

avatar richard67
richard67 - comment - 15 Nov 2024

It works for me in Postgresql 16.4, MySQL 8 and MariaDB 5.6 @richard67 I'm asking you to merge this PR

@softarius Could you mark your test result in the issue tracker https://issues.joomla.org/tracker/joomla-cms/44384 by using the blue "Test this" button at the top left corner, select your test result (success) and submit? Every non-trivial PR needs 2 successful human tests, and when you mark your test result 50% is done. Thanks in advance.

avatar softarius softarius - test_item - 15 Nov 2024 - Tested successfully
avatar softarius
softarius - comment - 15 Nov 2024

I have tested this item ✅ successfully on 840858f

Suceessfully tested in Postgresql 16.4, MySQL 8 and MariaDB 5.6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44384.
avatar richard67
richard67 - comment - 15 Nov 2024

@softarius Thanks for testing. Unfortunately I think this PR might not be in time for the upcoming 5.2.2 because packages for that version are already in preparation for being tested by the CMS Release Team, so it would be the next version after that, 5.2.3, which is planned for January 7, 2025. Not my responsibility or decision, I only report what I know. I will try my best to bring this PR forward, but I can't promise that it will help to bring it into 5.2.2.

avatar richard67 richard67 - test_item - 23 Nov 2024 - Tested successfully
avatar richard67
richard67 - comment - 23 Nov 2024

I have tested this item ✅ successfully on 840858f

Tested with PostgreSQL 16.4 and MySQL 8.0.40.

With PostgreSQL 16 without this PR in /var/log/postgresql/postgresql-16-main.log:

2024-11-23 14:17:20.339 CET [5520] jdb2adm@joomladb2 ERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list at character 288
2024-11-23 14:17:20.339 CET [5520] jdb2adm@joomladb2 STATEMENT:  SELECT DISTINCT(t.term)
	FROM "#__finder_terms" AS "t"
	INNER JOIN "#__finder_links_terms" AS "tm" ON tm.term_id = t.term_id
	INNER JOIN "#__finder_links" AS "l" ON (tm.link_id = l.link_id)
	WHERE t.term_id IN ($1) AND l.access IN (1,5) AND l.state = 1 AND l.published = 1
	ORDER BY t.links DESC,t.weight DESC LIMIT 10

With this PR no such log, and finder suggestions are shown.

With MySQL 8.0 with this PR it works as well as without this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44384.
avatar richard67 richard67 - change - 23 Nov 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 23 Nov 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44384.

avatar Hackwar Hackwar - change - 27 Nov 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-11-27 14:07:12
Closed_By Hackwar
Labels Added: RTC bug
avatar Hackwar Hackwar - close - 27 Nov 2024
avatar Hackwar Hackwar - merge - 27 Nov 2024
avatar Hackwar
Hackwar - comment - 27 Nov 2024

Thank you for your contribution!

Add a Comment

Login with GitHub to post a comment