[#44381] - [5.3] Replace InstallerScript class with a trait
- Pending
- Medium
- Build: 5.3-dev
- # 44381
- Diff
- bembelimen:5.3/installation-script-trait
User tests: Successful: Unsuccessful:
Summary of Changes
This implements a trait to be used in combination with the InstallerScriptInterface
Testing Instructions
I have no real idea, how to test it. You need an Extension using a install script with the InstallerScriptInterface. Using this trait should resolve the interface and give you some additional options like:
you can set
- a minimum PHP version which is required
- a minimum Joomla! version which is required
- files to be removed
- creating a dashboard menu onthefly
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.3-dev
|
||
What's the value of deprecating and forcing people to move. I mean I'm not fussed whether we use a base class or a trait to be honest - but I don't see the value of just deprecating and moving to the other one forcing code changes for next to no benefit.
I miss an interface for this trait and I would replace the string type with an enum.
I think the goal is to get type safety with out b/c break.
The interface exists already, but I couldn't change the InstallerClass without braking bc at the time I made it.
In general I'm not sure if the trait is the right approach. I would prefer a base class.