[#44381] - [6.0] Fulfill InstallerScriptInterface with a trait
- Fixed in Code Base
- 16 Aug 2025
- Medium
- Build: 5.3-dev
- # 44381
- Diff
- bembelimen:5.3/installation-script-trait
User tests: Successful: Unsuccessful:
Summary of Changes
This implements a trait to be used in combination with the InstallerScriptInterface
Testing Instructions
I have no real idea, how to test it. You need an Extension using a install script with the InstallerScriptInterface. Using this trait should resolve the interface and give you some additional options like:
you can set
- a minimum PHP version which is required
- a minimum Joomla! version which is required
- files to be removed
- creating a dashboard menu onthefly
There are also two "custom" methods to extend preflight/postflight and still benefit from their functionality.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org: joomla/Manual#448
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.3-dev
|
||
What's the value of deprecating and forcing people to move. I mean I'm not fussed whether we use a base class or a trait to be honest - but I don't see the value of just deprecating and moving to the other one forcing code changes for next to no benefit.
I miss an interface for this trait and I would replace the string type with an enum.
I think the goal is to get type safety with out b/c break.
The interface exists already, but I couldn't change the InstallerClass without braking bc at the time I made it.
| Labels |
Added:
Feature
|
||
This pull request has been automatically rebased to 6.0-dev.
| Title |
|
||||||
| Labels |
Added:
PR-6.0-dev
Removed: PR-5.3-dev |
||
| Title |
|
||||||
| Title |
|
||||||
Shouldn't there be the option to set dB requirements
Shouldn't there be the option to set dB requirements
It's not in the original, but it would be a nice improvement
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-16 15:10:21 |
| Closed_By | ⇒ | softforge |
Thank you for the work on this, and for the testers adn reviewers who pointed out some improvements that can be made
In general I'm not sure if the trait is the right approach. I would prefer a base class.