RTC Release Blocker bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar leeroy1821
leeroy1821
30 Oct 2024

Pull Request for Issue #44377 .

Summary of Changes

Move convertRelativeToAbsoluteUrls after replaceTags

Testing Instructions

Mail template com_users.password_reset, HTML Body:

<p>Hello,</p>
<p>
	A request has been made to reset your {SITENAME} account password. To reset your password, you will need to submit this verification code to verify that the request was legitimate.
</p>
<p>
    The verification code is {TOKEN}
</p>
<p>
	Click <a href="{LINK_HTML}">here</a> and proceed with resetting your password.    
</p>
<p>
    Thank you.
</p>

Go frontent.

Forgot your password?

Check email Joomla sent you.

Actual result BEFORE applying this Pull Request

URL in email is broken: https://www.mysite.com/https://www.mysite.com/component/users/reset.html?layout=confirm&amp;token=blablabla&amp;Itemid=123

The https://www.mysite.com is dobled in email.

Expected result AFTER applying this Pull Request

URL in email is correct: https://www.mysite.com/component/users/reset.html?layout=confirm&amp;token=blablabla&amp;Itemid=123

No dobled https://www.mysite.com in email.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar leeroy1821 leeroy1821 - open - 30 Oct 2024
avatar leeroy1821 leeroy1821 - change - 30 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2024
Category Libraries
avatar Quy Quy - test_item - 31 Oct 2024 - Tested successfully
avatar Quy
Quy - comment - 31 Oct 2024

I have tested this item ✅ successfully on 32525d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44378.

avatar viocassel viocassel - test_item - 31 Oct 2024 - Tested successfully
avatar viocassel
viocassel - comment - 31 Oct 2024

I have tested this item ✅ successfully on 32525d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44378.

avatar alikon alikon - change - 31 Oct 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 31 Oct 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44378.

avatar HLeithner HLeithner - change - 31 Oct 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-10-31 10:34:18
Closed_By HLeithner
Labels Added: RTC Release Blocker bug PR-5.2-dev
avatar HLeithner HLeithner - close - 31 Oct 2024
avatar HLeithner HLeithner - merge - 31 Oct 2024
avatar HLeithner
HLeithner - comment - 31 Oct 2024

thanks

Add a Comment

Login with GitHub to post a comment