RTC PR-5.2-dev Guided Tours Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
29 Oct 2024

Summary of Changes

This PR adds the missing getRedirectToListAppend function in the Step Controller that adds the missing tour_id query in the steps URL after returning from step edition.

Testing Instructions

Go to the Global Configuration, 'System' tab.
Set the session lifetime to 2mn.

Go to System -> Manage -> Guided Tours and go to the list of steps for a tour.
The URL in the browser address bar will be something like:
administrator/index.php?option=com_guidedtours&view=steps&tour_id=X

Edit a step. Cancel the edition (Select 'close').
The URL is now:
administrator/index.php?option=com_guidedtours&view=steps

Let the session run out.
Log back in.

Actual result BEFORE applying this Pull Request

When the user logs back in, the page is blank.

Expected result AFTER applying this Pull Request

When the user logs back in, the list of steps is available.
The URL when returning from step edition is:
administrator/index.php?option=com_guidedtours&view=steps&tour_id=X
(the tour_id query is always present).

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar obuisard obuisard - open - 29 Oct 2024
avatar obuisard obuisard - change - 29 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2024
Category Administration
avatar obuisard obuisard - change - 30 Oct 2024
Labels Added: PR-5.2-dev Guided Tours
avatar fgsw fgsw - test_item - 30 Oct 2024 - Tested successfully
avatar fgsw
fgsw - comment - 30 Oct 2024

I have tested this item ✅ successfully on 9e0522c

Comment: Like to test your Pull Requests; easy understandable Instructions.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44375.

avatar richard67 richard67 - change - 30 Oct 2024
The description was changed
avatar richard67 richard67 - edited - 30 Oct 2024
avatar viocassel viocassel - test_item - 30 Oct 2024 - Tested successfully
avatar viocassel
viocassel - comment - 30 Oct 2024

I have tested this item ✅ successfully on 9e0522c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44375.

avatar Quy Quy - change - 31 Oct 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 Oct 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44375.

avatar Hackwar Hackwar - change - 31 Oct 2024
Labels Added: RTC
avatar Hackwar Hackwar - close - 31 Oct 2024
avatar Hackwar Hackwar - merge - 31 Oct 2024
avatar Hackwar Hackwar - change - 31 Oct 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-10-31 11:20:57
Closed_By Hackwar
avatar Hackwar
Hackwar - comment - 31 Oct 2024

Thank you for your contribution!

Add a Comment

Login with GitHub to post a comment