[#4432] - Disregard this, PR to wrong branch :)
- Closed
- 2 Oct 2014
- Medium
- Build: master
- # 4432
- Diff
- PhilETaylor:IISBugDSDefines
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This pull request fixes some IIS compatibility issues where, under some circumstances, when browsing to the example.com/administrator/index.php the following defines are created:
JPATH_BASE = /path/to/site\administrator
JPATH_ADMINISTRATOR = /path/to/site/administrator
Note the wrong \ in the JPATH_BASE
In /libraries/joomla/uri/uri.php we compare JPATH_BASE and JPATH_ADMINISTRATOR with == to see if we should prefix the uri with /administrator or not, and as they are not the same, no /administrator prefix is applied to urls.
The symptom of this will then be, all the urls generated for the Joomla Admin Login page will have a relative URL starting at / and not /administrator which can be easily seen as the Joomla logo doesn't load, and when attempting to login, the form posts to /index.php and not /administrator/index.php and then gives a 404/500 error depending on config.
This PR is fully backward compatible
Head Nod to @redevo for giving me crazy server configs to work with :-)
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-02 13:01:31 |
Pull requests to the master branch of this repo are not accepted. Please close this pull request and submit a new one against the staging branch.
This is an automated message from the J!Tracker Application.