[#44318] - [5.2] mod_menu php fixes
- Fixed in Code Base
- 14 Nov 2024
- Medium
- Build: 5.2-dev
- # 44318
- Diff
- chmst:admin-mod-menu-fixes
User tests: Successful: Unsuccessful:
Pull Request for Issue #44317
Summary of Changes
Set Variables correctly
Testing Instructions
see #44317
Actual result BEFORE applying this Pull Request
Deprecated messages and Undefined Property messages
Expected result AFTER applying this Pull Request
no messages
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
After applying the PR most of the core menu module disapears
| Labels |
Added:
PHP 8.x
PR-5.2-dev
|
||
I change this to draft as the behaviour with recover seems to be wrong.
Still not correct.
With this PR
Before enabling recovery
After enabling recovery
Thank you for testing. I cannot replicate that - in my test it is:
I have tested this item ✅ successfully on d62377f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318.
This video shows that the recovery mode does not work.
chrome_tUW7ufmkPe.mp4
I have not tested this item.
@brianteeman now i understand, what you meant.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318.
I think, it would be more clear, instead of your variable define of camel-case $itemLink:
if (substr($item->link, 0, 8) === 'special:') {
change to:
if (isset($item->link) && substr($item->link, 0, 8) === 'special:') {
@brianteeman I have re-opened your issue. This PR is a partial fix for PHP warnings but does not resolve the issue with recovery mode.
@brianteeman do you remember which version was correct?
| Category | Modules Administration | ⇒ | Modules Administration Libraries |
I have tested this item ✅ successfully on adac1a5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318.
I have tested this item ✅ successfully on adac1a5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318.
Ready to Commit?
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318.
pe7er
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-14 08:20:22 |
| Closed_By | ⇒ | pe7er | |
| Labels |
Added:
RTC
|
||
I have tested this item 🔴 unsuccessfully on 5f70630
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318.