[#44307] - [5.2] Pre-update check for extensions AllowDynamicProperties
- Ready to Commit
- Medium
- Build: 5.2-dev
- # 44307
- Diff
- alikon:patch-21
User tests: Successful: Unsuccessful:
Pull Request for Issue #44284 .
Summary of Changes
added #[\AllowDynamicProperties]
Testing Instructions
see #44284 .
Actual result BEFORE applying this Pull Request
deprecation
Expected result AFTER applying this Pull Request
no more derepcation
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
the only way I was able to reproduce the issue, has been to add a non standard "tag" <updatefromcli>false</updatefromcli> in the updateserver xml file
so we don't know the exact non standard tags that are defined in the updateserver xml file of the extensions for @obuisard it was <length></leght> i suspect, so to avoid errors the #[\AllowDynamicProperties] could be a good solution imho
I have found the extension that has <length> in the update server file and it's a VERY popular extension.
My point is, it will be happening on a lot of sites that have error reporting enabled.
I have tested this item ✅ successfully on fa35b85
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44307.
| Labels |
Added:
PHP 8.x
bug
PR-5.2-dev
|
||
| Status | Pending | ⇒ | Ready to Commit |
With the review of @rdeutz and the test of @obuisard I'm declaring this as RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44307.
Please add the necessary attributes instead of hiding the error with this code.